set makefile target internal/mkcw/embed/entrypoint.gz as .PHONY on non x86_64 #5183
Conversation
|
@dcermak Could you please reduce the length of commit message. |
dcermak
force-pushed
the
fix-makefile-non-x86_64
branch
from
655fc09
to
fb455ce
Compare
done |
|
LGTM |
There was a problem hiding this comment.
This is not really the topic of this PR — fixing the build is much more important: When we commit the built .gz into git, I’m wondering about the risk of the source and the binary (accidentally or intentionally) getting out of sync.
It Would Be Nice™️ if our CI builds always validated that the .s and .gz, as they are checked into git, match.
The target internal/mkcw/embed/entrypoint is only built on x86_64, but internal/mkcw/embed/entrypoint.gz is run on all arches. This causes build failures on anything non x86_64 as internal/mkcw/embed/entrypoint is not build. Signed-off-by: Dan Čermák <dcermak@suse.com>
dcermak
force-pushed
the
fix-makefile-non-x86_64
branch
from
fb455ce
to
12b205f
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcermak, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The target internal/mkcw/embed/entrypoint is only built on x86_64, but internal/mkcw/embed/entrypoint.gz is run on all arches. This causes build failures on anything non x86_64 as internal/mkcw/embed/entrypoint is not build.
What type of PR is this?
/kind bug
What this PR does / why we need it:
To support running
makeon anything non x86_64.How to verify it
Run
makeon a non-x86_64 machine.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?