stage_executor,heredoc: honor interpreter in heredoc #5255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
If there are any shebang in heredoc file then buildah must honor that.
Consider a case of
```Dockerfile
FROM python:3.11-slim-bullseye
RUN <<EOF
print('hello world')
EOF
```
Closes: containers#5251
Signed-off-by: flouthoc <flouthoc.git@gmail.com>
flouthoc
force-pushed
the
heredoc-shebang
branch
from
0224c97
to
4cc811f
Compare
|
Rebased. |
|
@nalind @containers/build-maintainers PTAL |
|
LGTM |
|
@TomSweeneyRedHat I think rebased worked but it added additional commit, you can remove it with button (squash and merge) |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are any shebang in heredoc file then buildah must honor that. Consider a case of
Closes: #5251
What type of PR is this?
What this PR does / why we need it:
How to verify it
New Integration test
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?