stage_executor,layers: burst cache of layers if heredoc content is changed
#5261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@containers/buildah-maintainers PTAL |
|
LGTM |
Luap99
reviewed
Jan 11, 2024
|
LGTM after the two extra files are removed |
|
LGTM after comments addresses |
flouthoc
force-pushed
the
heredoc-add-to-history
branch
from
0af4509
to
14bcb82
Compare
|
Done. |
flouthoc
force-pushed
the
heredoc-add-to-history
branch
2 times, most recently
from
a39392e
to
6dc71f6
Compare
When using buildah with `--layers` then buildah must correctly burst layer cache if `heredoc` content is changed. Following is achieved via properly adding `heredoc` content to the history of the built image. Closes: containers#5225 Signed-off-by: flouthoc <flouthoc.git@gmail.com>
flouthoc
force-pushed
the
heredoc-add-to-history
branch
from
6dc71f6
to
339839d
Compare
|
/lgtm |
edsantiago
reviewed
Feb 5, 2024
|
|
||
| # on third run since we have changed heredoc so `Cache burst` must be printed. | ||
| run_buildah build $WITH_POLICY_JSON --layers -t source -f $contextdir/Dockerfile | ||
| expect_output --substring "Cache burst" |
There was a problem hiding this comment.
Suggestion: "Cache burst add diff"
There was a problem hiding this comment.
@edsantiago I have fixed this is a new PR with another feature: #5314
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using buildah with
--layersthen buildah must correctly burst layer cache ifheredoccontent is changed. Following is achieved via properly addingheredoccontent to the history of the built image.Closes: #5225
What type of PR is this?
What this PR does / why we need it:
Closes: #5225
How to verify it
Newly added integration test
Which issue(s) this PR fixes:
Closes: #5225
Special notes for your reviewer:
Does this PR introduce a user-facing change?