Use reversed logo for dark theme in README #5287
Conversation
openshift-ci
bot
added
the
kind/documentation
|
@Sea-n thanks for the PR. This can't be merged now as the branch needed to be updated, and one of the CI tests failed. I think it was a bogus test failure and I'm hoping the update I just kicked off will fix it. FWIW, in Dark mode for me, prior to this change, the word "Build" was all in black. I can clearly see it, at least while using Firefox, but I can understand how others might not pick it up as easily. I do like the change that you have made, regardless, so once we get happy tests, we can move forward with this. Thanks! @mairin if you have a quick moment to take a peak, I'd appreciate it. |
Signed-off-by: Sean Wei <me@sean.taipei>
|
Oh thanks, I've rebase'd and force-pushed the commit. With |
|
@TomSweeneyRedHat looks perfect to me!!!! Thank you for the fix @Sea-n!! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, Sea-n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Currently the name
buildahonly showsahin dark mode.How to verify it
Open my forked repo: https://github.com/Sea-n/buildah#readme
And maybe change
<html data-color-mode="auto">tolightanddarkto verify.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?
No