tests: Remove a bad FROM line #5291
Conversation
Some new heredoc test added "FROM blah blah python whatever", an image that (presumably) exists on docker.io but does not exist in our cache. Plus, test was completely broken anyway. It would've found the "this is the output" lines even without python, as part of the verbose build. Solution: don't use python. You don't need python to test a shebang. You can use anything. 'cat' is traditional, but I choose 'rev' because that makes it nearly impossible for the test to match merely due to a build-step echo. Signed-off-by: Ed Santiago <santiago@redhat.com>
|
Caught by podman-buildah treadmill |
There was a problem hiding this comment.
Test was added by me @edsantiago 😅 , my intention was to just test if other interpreted languages can directly run code from containerfile.
But I agree rev is a cleaner and low-footprint method to test this, thank you so much for fixing this 😄
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@edsantiago If i got your second concern right for the build-step echo part I don't think that buildah prints heredoc content in the build output so everything between the heredoc content is just executed it is not printed on the build step output if that is what you were talking about. |
It is, but I'm much more paranoid than you :-). If buildah is working properly, heredoc content is not printed. I can easily envision many forms of breakage in which heredoc is just passed through. Usually these would be errors, but I can also envision a missing error exit. And in that case: if a test only does a substring lookup for "hi there", it would pass. That's why as a general rule I always require tests to do some sort of text transform: Great to hear from you! I hope your new adventures are treating you well! |
| print('this is the output of test12') | ||
| #!/usr/bin/env rev | ||
| 11tset fo tuptuo eht si siht | ||
| 21tset fo tuptuo eht si siht |
There was a problem hiding this comment.
For a brief dyslexic moment, I thought you had dropped a naughty word at the end of these lines....
|
LGTM |
|
/lgtm |
Some new heredoc test added "FROM blah blah python whatever",
an image that (presumably) exists on docker.io but does not
exist in our cache.
Plus, test was completely broken anyway. It would've found
the "this is the output" lines even without python, as
part of the verbose build.
Solution: don't use python. You don't need python to test a shebang.
You can use anything. 'cat' is traditional, but I choose 'rev'
because that makes it nearly impossible for the test to match
merely due to a build-step echo.
Signed-off-by: Ed Santiago santiago@redhat.com