Fix FreeBSD version parsing #5296
Merged
+80
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was generating an error when parsing "14.0-RELEASE-p4" due to a stupid bug when attempting to check that the version part only has two parts. Signed-off-by: Doug Rabson <dfr@rabson.org>
flouthoc
approved these changes
Jan 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Test failure has nothing to do with this change so force merging to save the planet |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was generating an error when parsing "14.0-RELEASE-p4" due to a stupid bug when attempting to check that the version part only has two parts.
When I wrote this originally, I was using systems running either 13.2-STABLE or 14.0-CURRENT and didn't properly take into account the patchleve. This factors out the version parsing and adds a unit test.
What type of PR is this?
/kind bug
What this PR does / why we need it:
It forces Podman and Buildah to use two jails for each container instead of one when run on the latest iteration of FreeBSD 14.0
How to verify it
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?