Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build, heredoc: show heredoc summary in build output #5314

Merged
merged 2 commits into from
Feb 7, 2024
Merged

build, heredoc: show heredoc summary in build output #5314

merged 2 commits into from
Feb 7, 2024

Commits on Feb 2, 2024

  1. build, heredoc: show heredoc summary in build output 

    Buildah must show summary of heredoc content in build output so its easy
for developers to understand which heredoc got executed, this is similar
to what buildkit does for heredoc content.

See: https://github.com/moby/buildkit/blob/master/frontend/dockerfile/dockerfile2llb/convert.go#L1853

Sample output of buildah

```console
STEP 1/5: FROM docker.io/library/python:latest
STEP 2/5: RUN <<EOF (echo "Hello" >> /hello...)
STEP 3/5: RUN python3 <<EOF (with open("/hello", "w") as f:...)
STEP 4/5: RUN ls -a
```

Signed-off-by: flouthoc <flouthoc.git@gmail.com>
    @flouthoc
    flouthoc committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    1bfd333 View commit details
    Browse the repository at this point in the history

  2. tests: retrofit test for heredoc summary 

    Signed-off-by: flouthoc <flouthoc.git@gmail.com>
    @flouthoc
    flouthoc committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    533aac2 View commit details
    Browse the repository at this point in the history