Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] docs: correct default authfile path #5319

Merged
merged 1 commit into from Feb 6, 2024

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Feb 2, 2024

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Replaces #5294

@openshift-ci openshift-ci bot added the approved label Feb 2, 2024
@rhatdan
Copy link
Member Author

rhatdan commented Feb 3, 2024

@flouthoc @nalind @vrothberg @ashley-cui @wulfgarpro PTAL

@wulfgarpro
Copy link
Contributor

@rhatdan, auth.json is stored at /run/containers/0/auth.json when rootful.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer pointing to man containers-auth.json instead?

Signed-off-by: James Fraser <wulfgar.pro@gmail.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Member Author

rhatdan commented Feb 5, 2024

Modified to point at man page.

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nalind
Copy link
Member

nalind commented Feb 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4e9d2d5 into containers:main Feb 6, 2024
19 checks passed
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants