Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: skip_if_no_unshare(): check for --setuid #5360

Merged

Conversation

edsantiago
Copy link
Collaborator

unshare on RHEL8 does not support --setuid. This is causing
gating tests to fail.

Solution: check for option, skip test if unavailable

Signed-off-by: Ed Santiago santiago@redhat.com

None

unshare on RHEL8 does not support --setuid. This is causing
gating tests to fail.

Solution: check for option, skip test if unavailable

Signed-off-by: Ed Santiago <santiago@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Feb 28, 2024

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b1ba39f into containers:main Feb 28, 2024
36 checks passed
@edsantiago edsantiago deleted the skip_unshare_on_rhel branch February 28, 2024 12:05
edsantiago added a commit to edsantiago/buildah that referenced this pull request Feb 28, 2024
unshare on RHEL8 does not support --setuid. This is causing
gating tests to fail.

Solution: check for option, skip test if unavailable

Clean cherry-pick of containers#5360

Signed-off-by: Ed Santiago <santiago@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants