Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Stop rebasing renovate PRs automatically #5414

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Mar 18, 2024

What type of PR is this?

/kind other

What this PR does / why we need it:

Whenever a PR's target branch moves, Renovate was reconfigured to rebase
all of it's PRs and re-run CI. This is annoying for developers, stop
it.

How to verify it

After merging, renovate will stop automatically rebasing it's PRs.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Podman behaves as desired, it is also using the default setting of "do not rebase".

Does this PR introduce a user-facing change?

None

The one from github's container registry won't hit docker rate-limits.

Signed-off-by: Chris Evich <cevich@redhat.com>
Whenever a PR's target branch moves, Renovate was reconfigured to rebase
all of it's PRs and re-run CI.  This is annoying for developers, stop
it.

Signed-off-by: Chris Evich <cevich@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Mar 18, 2024

LGTM

@containers/podman-maintainers PTAL

@nalind @flouthoc @vrothberg @giuseppe @mheon PTAL

We are constantly rebuilding even when there is no conflict and this causes a waste of money, resources and time.

@mheon
Copy link
Member

mheon commented Mar 18, 2024

LGTM

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 07fb7d7 into containers:main Mar 18, 2024
21 checks passed
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants