Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expand RUN heredocs ourselves, let the shell do it #5473

Merged
merged 2 commits into from
May 20, 2024
Merged

Don't expand RUN heredocs ourselves, let the shell do it #5473

merged 2 commits into from
May 20, 2024

Commits on May 20, 2024

  1. Don't expand RUN heredocs ourselves, let the shell do it 

    When handling RUN instructions that use heredoc syntax, don't bother
interpolating environment variables and argument values, and let the
command that's running handle it.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
    @nalind
    nalind committed May 20, 2024
    Configuration menu
    Copy the full SHA
    97382f9 View commit details
    Browse the repository at this point in the history

  2. copierWithSubprocess(): try to capture stderr on io.ErrClosedPipe 

    When we get a tried-to-write-to-closed-pipe error while encoding
something for a coprocess, try to capture error output from the
coprocess and add it to the error message, to hopefully catch a flake
we're seeing in CI.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
    @nalind
    nalind committed May 20, 2024
    Configuration menu
    Copy the full SHA
    d9191e1 View commit details
    Browse the repository at this point in the history