netavark,NetworkUpdate: NetworkUpdateOptions must be IP addresses
#1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue was initially reported by @ypu. |
Luap99
reviewed
Mar 10, 2023
We enforced NetworkDNSServers to be IP addresses and we follow this enfore rule while a user is creating network, see comment containers#1237 (review) and PR containers#1237 Following check was missed in `NetworkUpdateOptions` hence add this check now. Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
network-update-validate-ip
branch
from
2dc9bb0
to
602f4b0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@flouthoc where was the issue reported? Can you provide a GitHub or Bugzilla URL please? |
|
@TomSweeneyRedHat it was reported in jira RUN-1739 ( in a comment ) I have tagged you there. |
|
Thanks @flouthoc! |
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Mar 30, 2023
We enforced NetworkDNSServers to be IP addresses and we follow this enfore rule while a user is creating network, see comment containers#1237 (review) and PR containers#1237 Following check was missed in `NetworkUpdateOptions` hence add this check now. Backport of: containers#1358 Signed-off-by: Aditya R <arajan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enforced
NetworkDNSServersto be IP addresses and we follow this enfore rule while a user is creating network, see comment #1237 (review) and PR #1237Following check was missed in
NetworkUpdateOptionshence add this check now.