Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete obsolete // +build lines #1780

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Jan 3, 2024

This PR removes outdated // +build build constraints. Use go fix ./... to remove the // +build lines that have become obsolete in Go 1.18. See https://go.dev/doc/go1.18#go-build-lines.

Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
@alexandear alexandear changed the title chore: remove outdated build constraints chore: delete obsolete // +build lines Jan 4, 2024
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the approved label Jan 4, 2024
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for contributing!

Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandear, Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d17f1c9 into containers:main Jan 4, 2024
7 checks passed
@alexandear alexandear deleted the remove-outdated-build-constraints branch January 4, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants