Drop warning to info on missing content from mounts.conf #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quay.io/buildah/stable and quay.io/podman/stable images now forward the mounts.conf subscriptions into their containers but if the host is not using subscription manager these pass throughs warn about missing files, which is not useful to the user. fixes: containers/podman#20812 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
changed the title
vrothberg
reviewed
Jan 16, 2024
|
Sure. Podman has a hidden field --default-mounts-file which we can point at a mounts file containing missing paths, and then make sure a container does not warn. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quay.io/buildah/stable and quay.io/podman/stable images now forward the mounts.conf subscriptions into their containers but if the host is not using subscription manager these pass throughs warn about missing files, which is not useful to the user.
fixes: containers/podman#20812