containers.conf: add crun-vm as a runtime

[lsm5]

No description provided.

[rhatdan]

/approve
LGTM
@giuseppe @vrothberg @ashley-cui @baude @mheon PTAL

[mheon]

Doesn't this need to be added to the default config as well?

[lsm5]

Doesn't this need to be added to the default config as well?

where exactly is that located?

[rhatdan]

https://github.com/containers/common/pull/1809/files#diff-f38944fdd6507cc37badbde5c66785bdebb77bd6fa2ea0674cd8117f89e95676R657

[mheon]

https://github.com/containers/common/blob/main/pkg/config/default.go#L357-L421 Was thinking it needed to go in there

[vrothberg]

Needs plumbing in the code, tests and docs. Maybe commit aec2850 can be of guidance for adding new fields to containers.conf.

[lsm5]

thanks all. I'll update this.

[lsm5]

Needs plumbing in the code, tests and docs. Maybe commit aec2850 can be of guidance for adding new fields to containers.conf.

doesn't look like we need anything of this sort here given it's only an additional option to OCIRuntimes. PTAL.

[vrothberg]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, rhatdan, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrothberg]

Needs plumbing in the code, tests and docs. Maybe commit aec2850 can be of guidance for adding new fields to containers.conf.

doesn't look like we need anything of this sort here given it's only an additional option to OCIRuntimes. PTAL.

Very fair point! I missed that we're adding a new runtime, not a new field. Thanks for clarifying!

[lsm5]

LGTM

thanks @vrothberg

@albertofaria PTAL at the diff of containers.conf.5.md

[rhatdan]

/lgtm