pkg/manifests.list.preferOCI() learn about some new OCI fields #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
The OCI image index structure has grown a few new fields since the last time we looked, so we should be paying attention to whether any of them are being used when deciding if we need to use the OCI format instead of the Docker format. The Docker format also grew a "URLs" field, so we can't use its mere presence as a heuristic any more. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
Had to remove the bit that checked if the manifest had annotations in its top level. The test that started with an OCI format, set "features" (a Docker-specific field) in an entry, and then saved and reloaded the manifest was getting an OCI format manifest back, which naturally did not include "features" information, so the test was failing. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OCI image index structure has grown a few new fields since the last time we looked, so we should be paying attention to whether any of them are being used when deciding if we need to use the OCI format instead of the Docker format.
The Docker format also grew a "URLs" field, so we can't use its mere presence as a heuristic any more.