Make timezone work on freebsd #1821
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rhatdan
force-pushed
the
freebsd
branch
2 times, most recently
from
66993eb
to
9f6a950
Compare
rhatdan
changed the title
|
@dfr @mheon @vrothberg @giuseppe @baude @Luap99 @umohnani8 @nalind @ashley-cui PTAL The PR for this has been verified on freebsd. |
|
LGTM |
pkg/timezone/timezone_linux.go
Outdated
| ) | ||
|
|
||
| func openDirectory(path string) (fd int, err error) { | ||
| return unix.Open(path, unix.O_RDONLY|unix.O_PATH, 0) |
There was a problem hiding this comment.
can we add unix.O_CLOEXEC here too?
|
LGTM. Note: now that FreeBSD 12.4 is EOL, it should be possible to add O_PATH and other nice things (e.g. netlink) to x/sys/unix on FreeBSD which will allow for future simplification here. |
|
LGTM once comments addressed |
Timezone code is broken on freebsd. Need to vendor into Podman to allow better sharing of code. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
No description provided.