Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix podman system df panic #1824

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

JoshVanL
Copy link
Contributor

Fix panic when running podman system df where a node.layer is nil.

Fixes containers/podman#20942

Fix panic when running `podman system df` where a `node.layer` is nil.

Fixes containers/podman#20942

Signed-off-by: joshvanl <me@joshvanl.dev>
@rhatdan
Copy link
Member

rhatdan commented Jan 25, 2024

/approve
LGTM

libimage/layer_tree.go Outdated Show resolved Hide resolved
… traversed

Signed-off-by: joshvanl <me@joshvanl.dev>
@rhatdan
Copy link
Member

rhatdan commented Jan 26, 2024

@umohnani8
Copy link
Member

LGTM

@mheon
Copy link
Member

mheon commented Jan 26, 2024

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, mheon, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 983ccb9 into containers:main Jan 26, 2024
7 checks passed
@hasan4791
Copy link
Contributor

hasan4791 commented Feb 22, 2024

In which podman version this fix would be expected?
I have 4.9.0 version and still having this issue!!!

As a workaround currently clearing the images with no tags.

podmanImageClean() {
    for i in $(podman images | grep "<none>" | awk '{print $3}');
    do  
        podman rmi -f $i
    done
}

@Luap99
Copy link
Member

Luap99 commented Feb 22, 2024

5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic in "podman system df"
6 participants