-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't error out on secret create --replace on missing secret #1909
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ashley-cui @vrothberg @Luap99 PTAL |
you didn't commit your new define dir I assume? |
@@ -126,18 +116,18 @@ func (d *Driver) Lookup(id string) ([]byte, error) { | |||
return nil, err | |||
} | |||
if err := d.gpg(context.TODO(), nil, out, "--decrypt", key); err != nil { | |||
return nil, fmt.Errorf("%s: %w", id, errNoSecretData) | |||
return nil, fmt.Errorf("%s: %w", id, define.ErrNoSuchSecret) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't change the current behavior but I am not sure this should return this error here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can we vendor this one into a Podman PR?
LGTM but bad lint |
Consolidate all errors between the different secret drivers. Fixes: containers/podman#22000 Fixes: containers/podman#21952 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Consolidate all errors between the different secret drivers.
Fixes: containers/podman#22000
Fixes: containers/podman#21952