Specify the recommended defaults for security #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@containers/podman-maintainers PTAL |
In Fedora Rawhide, I have eliminated some CAPABILITIES from the default list to make containers more secure. The containers.conf should be listed here as well. The default list in code is still the Docker defaults, but I have eliminated three from the default list AUDIT_WRITE, MKNOD, NET_RAW In Fedora 33 we have eliminated just MKNOD and NET_RAW. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
@containers/podman-maintainers PTAL again. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vrothberg Yes step one is to get this file merged into common, then we can setup tests to use this containers.conf by default in the vendored subdir or podman. This means we would at least realize breakage in the podman tests when a new version of containers/common got vendored in. |
|
/lgtm |
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Jan 7, 2021
This test fails after updating to new VM images which include containers/common#319 Work around the problem by adding in the capabilities expected to be present. Thanks to @edsantiago and @giuseppe for the fix. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Jan 7, 2021
This test fails after updating to new VM images which include containers/common#319 Work around the problem by adding in the capabilities expected to be present. Thanks to @edsantiago and @giuseppe for the fix. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Jan 11, 2021
This test fails after updating to new VM images which include containers/common#319 Work around the problem by adding in the capabilities expected to be present. Thanks to @edsantiago and @giuseppe for the fix. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Jan 12, 2021
This test fails after updating to new VM images which include containers/common#319 Work around the problem by adding in the capabilities expected to be present. Thanks to @edsantiago and @giuseppe for the fix. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Jan 12, 2021
This test fails after updating to new VM images which include containers/common#319 Work around the problem by adding in the capabilities expected to be present. Thanks to @edsantiago and @giuseppe for the fix. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/buildah
that referenced
this pull request
Feb 15, 2021
This test fails after updating to new VM images which include containers/common#319 Work around the problem by adding in the capabilities expected to be present. Thanks to @edsantiago and @giuseppe for the fix. Signed-off-by: Chris Evich <cevich@redhat.com>
M1cha
pushed a commit
to M1cha/common
that referenced
this pull request
Dec 20, 2022
update rtnetlink lib to 0.10.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Fedora Rawhide, I have eliminated some CAPABILITIES from the
default list to make containers more secure. The containers.conf
should be listed here as well. The default list in code is still
the Docker defaults, but I have eliminated three from the default
list
AUDIT_WRITE, MKNOD, NET_RAW
In Fedora 33 we have eliminated just MKNOD and NET_RAW.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com