adjust log-driver defaults #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 98ff7e1 changed the default logging driver k8s-file to journald. The only consumer of the log-driver is Podman which I think still needs some more time to stabilize. Vendoring containers/common into Podman has revealed quite some warts (see containers/podman/pull/10222) which reduced my confidence level. To resolve the chicken-egg-problem of maturing the journald driver, I want to only partially revert commit 98ff7e1. The built-in default remains k8s-file while the containers.conf sets it to journald. The intention behind is to make sure that running systems are not impacted but we can change Fedora to journald to increase coverage. Once the confidence level is back to normal, we can change the default to journald. Latest before RHEL9. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
rhatdan
reviewed
May 12, 2021
|
I am going to merge so we can cut a release, but I think we should disable the containers.conf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 98ff7e1 changed the default logging driver k8s-file to
journald. The only consumer of the log-driver is Podman which I think
still needs some more time to stabilize. Vendoring containers/common
into Podman has revealed quite some warts (see
containers/podman/pull/10222) which reduced my confidence level.
To resolve the chicken-egg-problem of maturing the journald driver, I
want to only partially revert commit 98ff7e1. The built-in default
remains k8s-file while the containers.conf sets it to journald. The
intention behind is to make sure that running systems are not impacted
but we can change Fedora to journald to increase coverage.
Once the confidence level is back to normal, we can change the default
to journald. Latest before RHEL9.
Signed-off-by: Valentin Rothberg rothberg@redhat.com
As discussed in yesterday's meeting: @rhatdan @containers/podman-maintainers PTAL