Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libimage: events: deferred write #655

Merged
merged 1 commit into from Jun 30, 2021
Merged

libimage: events: deferred write #655

merged 1 commit into from Jun 30, 2021

Conversation

vrothberg
Copy link
Member

Some users rely on events being written after the operation ran.
Hence, defer all event writes.

Context: containers/podman/issues/10812
Signed-off-by: Valentin Rothberg rothberg@redhat.com

@vrothberg
libimage: events: deferred write
8d1de10 
Some users rely on events being written *after* the operation ran.
Hence, defer all event writes.

Context: containers/podman/issues/10812
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
saschagrunert
saschagrunert approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg vrothberg mentioned this pull request Jun 30, 2021
Closed
@vrothberg
Copy link
Member Author

@rhatdan @Luap99 PTAL

@rhatdan
Copy link
Member

rhatdan commented Jun 30, 2021

What happens if there is an error and the event actually doesn't happen?
This is better then what we have, but should we check if the function returned an error and add event like XYZ Failed to tag ABC
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7482cf8 into containers:main Jun 30, 2021
@vrothberg vrothberg deleted the events-fix branch June 30, 2021 09:21
@vrothberg
Copy link
Member Author

What happens if there is an error and the event actually doesn't happen?

Then the event will be written as well. I think it would be a good exercise (maybe for kabal) to decide the semantics of events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@rhatdan rhatdan

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vrothberg @rhatdan @saschagrunert @openshift-merge-robot