Skip to content

Commit

Permalink
Remove unnecessary SetRequest calls
Browse files Browse the repository at this point in the history
Signed-off-by: Martin Michaelis <code@mgjm.de>
  • Loading branch information
mgjm committed Jul 12, 2023
1 parent f132a00 commit 6e902ef
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
4 changes: 0 additions & 4 deletions pkg/client/attach.go
Original file line number Diff line number Diff line change
Expand Up @@ -499,10 +499,6 @@ func (c *ConmonClient) SetWindowSizeContainer(ctx context.Context, cfg *SetWindo
req.SetWidth(cfg.Size.Width)
req.SetHeight(cfg.Size.Height)

if err := p.SetRequest(req); err != nil {
return fmt.Errorf("set request: %w", err)
}

return nil
})
defer free()
Expand Down
11 changes: 0 additions & 11 deletions pkg/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -724,10 +724,6 @@ func (c *ConmonClient) CreateContainer(
return fmt.Errorf("convert cleanup command string slice to text list: %w", err)
}

if err := p.SetRequest(req); err != nil {
return fmt.Errorf("set request: %w", err)
}

return nil
})
defer free()
Expand Down Expand Up @@ -813,9 +809,6 @@ func (c *ConmonClient) ExecSyncContainer(ctx context.Context, cfg *ExecSyncConfi
return err
}
req.SetTerminal(cfg.Terminal)
if err := p.SetRequest(req); err != nil {
return fmt.Errorf("set request: %w", err)
}

return nil
})
Expand Down Expand Up @@ -980,10 +973,6 @@ func (c *ConmonClient) ReopenLogContainer(ctx context.Context, cfg *ReopenLogCon
return fmt.Errorf("set ID: %w", err)
}

if err := p.SetRequest(req); err != nil {
return fmt.Errorf("set request: %w", err)
}

return nil
})
defer free()
Expand Down

0 comments on commit 6e902ef

Please sign in to comment.