Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant serialization of OOMExitPaths #1441

Conversation

mgjm
Copy link
Contributor

@mgjm mgjm commented Jun 27, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Merging of 22a1616 and c354aaf resulted in redundant serialization of the OOMExitPaths field.

Special notes for your reviewer:

Both commits introduced the OOMExitPaths field and added serialization code.

Does this PR introduce a user-facing change?

None

Signed-off-by: Martin Michaelis <code@mgjm.de>
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgjm, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #1441 (2087e1d) into main (3df0d88) will increase coverage by 0.52%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
+ Coverage   34.00%   34.53%   +0.52%     
==========================================
  Files          13       13              
  Lines        1135     1135              
  Branches      392      393       +1     
==========================================
+ Hits          386      392       +6     
+ Misses        493      483      -10     
- Partials      256      260       +4     

@openshift-merge-robot openshift-merge-robot merged commit c8ed0f4 into containers:main Jun 27, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants