Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
This updates the
update-proto
rule in the Makefile to be more robust und work with go version 1.20.880e0b7 creates an intermediate file in
internal/proto/conmon.capnp
with the required changes for gocapnp compile
step failed the applied changes didn't get reverted, when tried again the patch was applied twicegit checkout
at the end did remove my uncommitted changes 馃槩17780b4 updates the make rule to be compatible with go version 1.20
go install
no longer places source code in$GOPATH/src
$GOMODCACHE = $GOPATH/pkg/mod
used bygo install
in module modego.mod
file (instead oflatest
)Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Verify that this change also works with older go versions (depending on the minimum required go version). I could not figure out in wich version go switched to the
GOMODCACHE
directory forgo install
.And check that the grep rule works. Tested on Alpine and Arch Linux.
Does this PR introduce a user-facing change?