New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streaming server #2070
base: main
Are you sure you want to change the base?
Add streaming server #2070
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2070 +/- ##
==========================================
- Coverage 37.53% 37.25% -0.29%
==========================================
Files 15 16 +1
Lines 1268 1353 +85
Branches 414 455 +41
==========================================
+ Hits 476 504 +28
- Misses 526 543 +17
- Partials 266 306 +40 |
+1 to axum. Can we use a domain socket instead of a tcp socket? |
I have to check if Kubernetes supports that, but generally yes 👍 |
0ddb3d9
to
a875baa
Compare
a875baa
to
a116a19
Compare
a116a19
to
7cada3a
Compare
No, it's currently not due to: |
b5702dc
to
09e759e
Compare
8fee4a4
to
00e793b
Compare
00e793b
to
af23b30
Compare
63eaf91
to
2b217c2
Compare
@rphillips @haircommander PTAL |
2b217c2
to
fa341c4
Compare
5db6e69
to
a9bbf07
Compare
a9bbf07
to
0e04aab
Compare
3977889
to
1f275b3
Compare
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
1f275b3
to
c0fc3cd
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding streaming server support.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Refers to cri-o/cri-o#7826
Does this PR introduce a user-facing change?