Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming server #2070

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Mar 18, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding streaming server support.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Refers to cri-o/cri-o#7826

Does this PR introduce a user-facing change?

Added streaming server support.

Copy link
Contributor

openshift-ci bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 33.00971% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 37.25%. Comparing base (4e0f474) to head (c0fc3cd).
Report is 395 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2070      +/-   ##
==========================================
- Coverage   37.53%   37.25%   -0.29%     
==========================================
  Files          15       16       +1     
  Lines        1268     1353      +85     
  Branches      414      455      +41     
==========================================
+ Hits          476      504      +28     
- Misses        526      543      +17     
- Partials      266      306      +40     

@rphillips
Copy link
Collaborator

+1 to axum. Can we use a domain socket instead of a tcp socket?

@saschagrunert
Copy link
Member Author

+1 to axum. Can we use a domain socket instead of a tcp socket?

I have to check if Kubernetes supports that, but generally yes 👍

@saschagrunert
Copy link
Member Author

+1 to axum. Can we use a domain socket instead of a tcp socket?

No, it's currently not due to:
https://github.com/kubernetes/client-go/blob/1518fca9f06c6a73fc091535b8966c71704e657b/transport/websocket/roundtripper.go#L109

@saschagrunert saschagrunert force-pushed the streaming-server branch 10 times, most recently from b5702dc to 09e759e Compare March 21, 2024 08:32
@saschagrunert
Copy link
Member Author

@rphillips @haircommander PTAL

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants