test: small tweaks to cri-o test process #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Hunt <pehunt@redhat.com>
| @@ -232,6 +230,7 @@ install_testing_deps() { | |||
| echo "Installing latest upstream version of BATS" | |||
| ooe.sh git clone https://github.com/bats-core/bats-core.git /tmp/bats | |||
| cd /tmp/bats | |||
| echo "Testing against bats commit: $(git rev-parse HEAD)" | |||
There was a problem hiding this comment.
if you're keeping this long term, you might want to tweak the space/tab issue here.
Signed-off-by: Peter Hunt <pehunt@redhat.com>
| @@ -76,6 +76,7 @@ ooe.sh sudo dnf -y install \ | |||
| openssl \ | |||
| openssl-devel \ | |||
| ostree-devel \ | |||
| parallel \ | |||
Signed-off-by: Peter Hunt <pehunt@redhat.com>
| @@ -22,7 +22,7 @@ install_ooe | |||
| echo "Updating packages" | |||
| ooe.sh sudo dnf update -y | |||
|
|
|||
| ooe.sh sudo dnf -y module install cri-o:1.13 | |||
| ooe.sh sudo dnf -y module install cri-o:1.17 | |||
There was a problem hiding this comment.
Do we already want to use 1.18 ❓
There was a problem hiding this comment.
baby steps 😆 this PR doesn't even work properly right now lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(really I want to debug why we're seeing
Error: Duplicate test name(s) in file "/var/tmp/go/src/github.com/cri-o/cri-o/test/./ctr_seccomp.bats": test_ctr_seccomp_profiles_runtime-2fdefaultand also not failing because we don't have parallel installed)Signed-off-by: Peter Hunt pehunt@redhat.com