Fix incorrect free in conn_sock #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier commit freed socket_parent_dir()'s result which is correct in the case it returns a path from g_build_filename, but when it returns opt_bundle_path the string should not be freed. Make the function always return an allocated string that can be freed Fixes: containers#475 Fixes: fad6bac ("fix some issues flagged by SAST scan") Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
|
(alternatively we could only free parent_dir if (!use_full_attach_path) in bind_unix_socket, but that seems more error-prone) |
|
@haircommander @giuseppe PTAL |
hswong3i
added a commit
to alvistack/containers-conmon
that referenced
this pull request
Dec 16, 2023
git clean -xdf
tar zcvf ../conmon_2.1.9+20231216.331c602d.orig.tar.gz --exclude=.git .
debuild -uc -us
cp conmon.spec ../conmon_2.1.9+20231216.331c602d-1.spec
cp ../conmon*2.1.9+20231216.331c602d*.{gz,xz,spec,dsc} /osc/home\:alvistack/containers-conmon-2.1.9+20231216.331c602d/
rm -rf ../conmon*2.1.9+20231216.331c602d*.*
See containers#476
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
pld-gitsync
pushed a commit
to pld-linux/conmon
that referenced
this pull request
Dec 16, 2023
amarshall
added a commit
to amarshall/nixpkgs
that referenced
this pull request
Dec 16, 2023
Should fix `nix-build -A podman.passthru.tests`, see bug report NixOS#274655 See also upstream: containers/conmon#476 containers/conmon#475 containers/conmon#477
13 tasks
hamburger1984
pushed a commit
to hamburger1984/nixpkgs
that referenced
this pull request
Dec 18, 2023
Should fix `nix-build -A podman.passthru.tests`, see bug report NixOS#274655 See also upstream: containers/conmon#476 containers/conmon#475 containers/conmon#477
vncsb
pushed a commit
to vncsb/nixpkgs
that referenced
this pull request
Dec 19, 2023
Should fix `nix-build -A podman.passthru.tests`, see bug report NixOS#274655 See also upstream: containers/conmon#476 containers/conmon#475 containers/conmon#477
Lainera
pushed a commit
to Lainera/nixpkgs
that referenced
this pull request
Dec 20, 2023
Should fix `nix-build -A podman.passthru.tests`, see bug report NixOS#274655 See also upstream: containers/conmon#476 containers/conmon#475 containers/conmon#477
adelton
added a commit
to adelton/freeipa-container
that referenced
this pull request
Jan 3, 2024
This reverts commit 811be42. Issue fixed via containers/conmon#476 and new conmon 2.1.10 which is now in https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/unstable/xUbuntu_22.04/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier commit freed socket_parent_dir()'s result which is correct in the case it returns a path from g_build_filename, but when it returns opt_bundle_path the string should not be freed.
Make the function always return an allocated string that can be freed
Fixes: #475
Fixes: fad6bac ("fix some issues flagged by SAST scan")