Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crun 1.4.1 fails to build with gcc 11.1.0 #854

Closed
freswa opened this issue Jan 18, 2022 · 1 comment · Fixed by #855
Closed

crun 1.4.1 fails to build with gcc 11.1.0 #854

freswa opened this issue Jan 18, 2022 · 1 comment · Fixed by #855

Comments

@freswa
Copy link

freswa commented Jan 18, 2022

crun 1.4 builds fine, but with the update to 1.4.1 compile fails with this error being printed:

python/crun_python.c: In function ‘container_kill’:
python/crun_python.c:236:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
  236 |   const char signal*;
      |                    ^
python/crun_python.c:236:21: error: expected expression before ‘;’ token
  236 |   const char signal*;
      |                     ^
giuseppe added a commit to giuseppe/crun that referenced this issue Jan 18, 2022
@giuseppe
python: fix build
2f5be74 
commit 21a8daf introduced the
regression.

Closes: containers#854

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe mentioned this issue Jan 18, 2022
Merged
@giuseppe
Copy link
Member

opened a PR: #855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

python: fix build giuseppe/crun
2 participants
@giuseppe @freswa