Implement crun features #1237

sohankunkerkar · 2023-06-20T19:23:30Z

Fixes: #1177

src/features.c

giuseppe

thanks for working on this. I've left some comments, also make sure make clang-format passes

src/features.c

src/libcrun/container.c

src/features.c

src/libcrun/container.c

src/features.c

.vscode/settings.json

giuseppe

some more small comments. Also this is a completely new feature, so we need some tests too under tests to run with make check

Makefile.am

src/features.c

src/libcrun/container.c

src/features.c

src/libcrun/container.c

tests/test_oci_features.py

giuseppe · 2023-06-25T07:00:07Z

src/libcrun/container.c

+  "SCMP_CMP_MASKED_EQ",
+};
+
+static const char *archs[] = {


I am still not sure if we must list the arches. Not only we risk to not list all the supported values, but we also risk that the dynamically linked version of libseccomp doesn't have support for what we are listing here.

What do you think? Wouldn't it be safer for now to just drop the arches list from the JSON output?

Yup, it makes sense. Does that sound good to you if we keep the reference of it in the code for the future but drop the entry from the final output for now?

I think it is better to remove the code altogether, we can easily add it back if we ever need it in this form

giuseppe · 2023-06-26T07:45:34Z

when I run the new test locally, I get the following error:

Complete features dictionary: {'ociVersionMin': '1.0.0', 'ociVersionMax': '1.1.0-rc.3', 'hooks': ['prestart', 'createRuntime', 'createContainer', 'startContainer', 'poststart', 'poststop'], 'mountOptions': ['rw', 'rrw', 'ro', 'rro', 'rdirsync', 'rdiratime', 'rnodev', 'rnorelatime', 'nodiratime', 'rnodiratime', 'diratime', 'rnoatime', 'rnomand', 'ratime', 'rmand', 'mand', 'idmap', 'noatime', 'nomand', 'dirsync', 'rnosuid', 'atime', 'rnoexec', 'nodev', 'rbind', 'norelatime', 'bind', 'rnostrictatime', 'strictatime', 'rstrictatime', 'rprivate', 'rsuid', 'remount', 'suid', 'nostrictatime', 'rrelatime', 'nosuid', 'noexec', 'rslave', 'dev', 'rdev', 'rsync', 'relatime', 'sync', 'shared', 'rshared', 'unbindable', 'runbindable', 'defaults', 'async', 'rasync', 'private', 'tmpcopyup', 'rexec', 'exec', 'slave'], 'linux': {'namespaces': ['cgroup', 'ipc', 'mount', 'network', 'pid', 'user', 'uts'], 'capabilities': ['CAP_CHOWN', 'CAP_DAC_OVERRIDE', 'CAP_DAC_READ_SEARCH', 'CAP_FOWNER', 'CAP_FSETID', 'CAP_KILL', 'CAP_SETGID', 'CAP_SETUID', 'CAP_SETPCAP', 'CAP_LINUX_IMMUTABLE', 'CAP_NET_BIND_SERVICE', 'CAP_NET_BROADCAST', 'CAP_NET_ADMIN', 'CAP_NET_RAW', 'CAP_IPC_LOCK', 'CAP_IPC_OWNER', 'CAP_SYS_MODULE', 'CAP_SYS_RAWIO', 'CAP_SYS_CHROOT', 'CAP_SYS_PTRACE', 'CAP_SYS_PACCT', 'CAP_SYS_ADMIN', 'CAP_SYS_BOOT', 'CAP_SYS_NICE', 'CAP_SYS_RESOURCE', 'CAP_SYS_TIME', 'CAP_SYS_TTY_CONFIG', 'CAP_MKNOD', 'CAP_LEASE', 'CAP_AUDIT_WRITE', 'CAP_AUDIT_CONTROL', 'CAP_SETFCAP', 'CAP_MAC_OVERRIDE', 'CAP_MAC_ADMIN', 'CAP_SYSLOG', 'CAP_WAKE_ALARM', 'CAP_BLOCK_SUSPEND', 'CAP_AUDIT_READ', 'CAP_PERFMON', 'CAP_BPF', 'CAP_CHECKPOINT_RESTORE'], 'cgroup': {'v1': True, 'v2': True, 'systemd': True, 'systemdUser': True}, 'seccomp': {'enabled': True, 'actions': ['SCMP_ACT_ALLOW', 'SCMP_ACT_ERRNO', 'SCMP_ACT_KILL', 'SCMP_ACT_KILL_PROCESS', 'SCMP_ACT_KILL_THREAD', 'SCMP_ACT_LOG', 'SCMP_ACT_NOTIFY', 'SCMP_ACT_TRACE', 'SCMP_ACT_TRAP'], 'operators': ['SCMP_CMP_NE', 'SCMP_CMP_LT', 'SCMP_CMP_LE', 'SCMP_CMP_EQ', 'SCMP_CMP_GE', 'SCMP_CMP_GT', 'SCMP_CMP_MASKED_EQ']}, 'apparmor': {'enabled': True}, 'selinux': {'enabled': True}}, 'annotations': {'io.github.seccomp.libseccomp.version': '2.5.3', 'org.opencontainers.runc.checkpoint.enabled': True, 'run.oci.crun.checkpoint.enabled': True, 'io.github.containers.crun.commit': '9738116147984a9fb6d993394f74217b0e532be8', 'io.github.containers.crun.version': '1.8.5.0.0.0.31-33cb'}}
Mismatch in feature: linux
Expected: {'namespaces': ['cgroup', 'ipc', 'mount', 'network', 'pid', 'user', 'uts'], 'capabilities': ['CAP_CHOWN', 'CAP_DAC_OVERRIDE', 'CAP_DAC_READ_SEARCH', 'CAP_FOWNER', 'CAP_FSETID', 'CAP_KILL', 'CAP_SETGID', 'CAP_SETUID', 'CAP_SETPCAP', 'CAP_LINUX_IMMUTABLE', 'CAP_NET_BIND_SERVICE', 'CAP_NET_BROADCAST', 'CAP_NET_ADMIN', 'CAP_NET_RAW', 'CAP_IPC_LOCK', 'CAP_IPC_OWNER', 'CAP_SYS_MODULE', 'CAP_SYS_RAWIO', 'CAP_SYS_CHROOT', 'CAP_SYS_PTRACE', 'CAP_SYS_PACCT', 'CAP_SYS_ADMIN', 'CAP_SYS_BOOT', 'CAP_SYS_NICE', 'CAP_SYS_RESOURCE', 'CAP_SYS_TIME', 'CAP_SYS_TTY_CONFIG', 'CAP_MKNOD', 'CAP_LEASE', 'CAP_AUDIT_WRITE', 'CAP_AUDIT_CONTROL', 'CAP_SETFCAP', 'CAP_MAC_OVERRIDE', 'CAP_MAC_ADMIN', 'CAP_SYSLOG', 'CAP_WAKE_ALARM', 'CAP_BLOCK_SUSPEND', 'CAP_AUDIT_READ', 'CAP_PERFMON', 'CAP_BPF', 'CAP_CHECKPOINT_RESTORE'], 'cgroup': {'v1': True, 'v2': True, 'systemd': True, 'systemdUser': True}, 'seccomp': {'actions': ['SCMP_ACT_ALLOW', 'SCMP_ACT_ERRNO', 'SCMP_ACT_KILL', 'SCMP_ACT_KILL_PROCESS', 'SCMP_ACT_KILL_THREAD', 'SCMP_ACT_LOG', 'SCMP_ACT_NOTIFY', 'SCMP_ACT_TRACE', 'SCMP_ACT_TRAP'], 'operators': ['SCMP_CMP_NE', 'SCMP_CMP_LT', 'SCMP_CMP_LE', 'SCMP_CMP_EQ', 'SCMP_CMP_GE', 'SCMP_CMP_GT', 'SCMP_CMP_MASKED_EQ']}, 'apparmor': {'enabled': True}, 'selinux': {'enabled': True}}
Actual: {'namespaces': ['cgroup', 'ipc', 'mount', 'network', 'pid', 'user', 'uts'], 'capabilities': ['CAP_CHOWN', 'CAP_DAC_OVERRIDE', 'CAP_DAC_READ_SEARCH', 'CAP_FOWNER', 'CAP_FSETID', 'CAP_KILL', 'CAP_SETGID', 'CAP_SETUID', 'CAP_SETPCAP', 'CAP_LINUX_IMMUTABLE', 'CAP_NET_BIND_SERVICE', 'CAP_NET_BROADCAST', 'CAP_NET_ADMIN', 'CAP_NET_RAW', 'CAP_IPC_LOCK', 'CAP_IPC_OWNER', 'CAP_SYS_MODULE', 'CAP_SYS_RAWIO', 'CAP_SYS_CHROOT', 'CAP_SYS_PTRACE', 'CAP_SYS_PACCT', 'CAP_SYS_ADMIN', 'CAP_SYS_BOOT', 'CAP_SYS_NICE', 'CAP_SYS_RESOURCE', 'CAP_SYS_TIME', 'CAP_SYS_TTY_CONFIG', 'CAP_MKNOD', 'CAP_LEASE', 'CAP_AUDIT_WRITE', 'CAP_AUDIT_CONTROL', 'CAP_SETFCAP', 'CAP_MAC_OVERRIDE', 'CAP_MAC_ADMIN', 'CAP_SYSLOG', 'CAP_WAKE_ALARM', 'CAP_BLOCK_SUSPEND', 'CAP_AUDIT_READ', 'CAP_PERFMON', 'CAP_BPF', 'CAP_CHECKPOINT_RESTORE'], 'cgroup': {'v1': True, 'v2': True, 'systemd': True, 'systemdUser': True}, 'seccomp': {'enabled': True, 'actions': ['SCMP_ACT_ALLOW', 'SCMP_ACT_ERRNO', 'SCMP_ACT_KILL', 'SCMP_ACT_KILL_PROCESS', 'SCMP_ACT_KILL_THREAD', 'SCMP_ACT_LOG', 'SCMP_ACT_NOTIFY', 'SCMP_ACT_TRACE', 'SCMP_ACT_TRAP'], 'operators': ['SCMP_CMP_NE', 'SCMP_CMP_LT', 'SCMP_CMP_LE', 'SCMP_CMP_EQ', 'SCMP_CMP_GE', 'SCMP_CMP_GT', 'SCMP_CMP_MASKED_EQ']}, 'apparmor': {'enabled': True}, 'selinux': {'enabled': True}}
not ok 1 - crun-features

giuseppe · 2023-06-26T07:49:17Z

we can't hardcode the list of capabilities in the test. We only need to verify some well known capabilities are in the list, e.g. CAP_SYS_ADMIN, CAP_KILL, CAP_NET_BIND_SERVICE

sohankunkerkar · 2023-06-26T12:52:03Z

we can't hardcode the list of capabilities in the test. We only need to verify some well known capabilities are in the list, e.g. CAP_SYS_ADMIN, CAP_KILL, CAP_NET_BIND_SERVICE

I can do this

def get_linux_capabilities():
    capabilities_file = '/proc/self/status'
    capabilities = []

    with open(capabilities_file, 'r') as file:
        lines = file.readlines()

    for line in lines:
        if line.startswith('Cap') and ':' in line:
            cap_name, cap_value = line.split(':', 1)
            cap_name = cap_name.strip()
            cap_value = cap_value.strip()
            if cap_name.startswith('CapBnd:'):
                cap_hex = cap_value.split()
                for cap in cap_hex:
                    cap_int = int(cap, 16)
                    capabilities.append(cap_int)

    return capabilities

when I run the new test locally, I get the following error:

Complete features dictionary: {'ociVersionMin': '1.0.0', 'ociVersionMax': '1.1.0-rc.3', 'hooks': ['prestart', 'createRuntime', 'createContainer', 'startContainer', 'poststart', 'poststop'], 'mountOptions': ['rw', 'rrw', 'ro', 'rro', 'rdirsync', 'rdiratime', 'rnodev', 'rnorelatime', 'nodiratime', 'rnodiratime', 'diratime', 'rnoatime', 'rnomand', 'ratime', 'rmand', 'mand', 'idmap', 'noatime', 'nomand', 'dirsync', 'rnosuid', 'atime', 'rnoexec', 'nodev', 'rbind', 'norelatime', 'bind', 'rnostrictatime', 'strictatime', 'rstrictatime', 'rprivate', 'rsuid', 'remount', 'suid', 'nostrictatime', 'rrelatime', 'nosuid', 'noexec', 'rslave', 'dev', 'rdev', 'rsync', 'relatime', 'sync', 'shared', 'rshared', 'unbindable', 'runbindable', 'defaults', 'async', 'rasync', 'private', 'tmpcopyup', 'rexec', 'exec', 'slave'], 'linux': {'namespaces': ['cgroup', 'ipc', 'mount', 'network', 'pid', 'user', 'uts'], 'capabilities': ['CAP_CHOWN', 'CAP_DAC_OVERRIDE', 'CAP_DAC_READ_SEARCH', 'CAP_FOWNER', 'CAP_FSETID', 'CAP_KILL', 'CAP_SETGID', 'CAP_SETUID', 'CAP_SETPCAP', 'CAP_LINUX_IMMUTABLE', 'CAP_NET_BIND_SERVICE', 'CAP_NET_BROADCAST', 'CAP_NET_ADMIN', 'CAP_NET_RAW', 'CAP_IPC_LOCK', 'CAP_IPC_OWNER', 'CAP_SYS_MODULE', 'CAP_SYS_RAWIO', 'CAP_SYS_CHROOT', 'CAP_SYS_PTRACE', 'CAP_SYS_PACCT', 'CAP_SYS_ADMIN', 'CAP_SYS_BOOT', 'CAP_SYS_NICE', 'CAP_SYS_RESOURCE', 'CAP_SYS_TIME', 'CAP_SYS_TTY_CONFIG', 'CAP_MKNOD', 'CAP_LEASE', 'CAP_AUDIT_WRITE', 'CAP_AUDIT_CONTROL', 'CAP_SETFCAP', 'CAP_MAC_OVERRIDE', 'CAP_MAC_ADMIN', 'CAP_SYSLOG', 'CAP_WAKE_ALARM', 'CAP_BLOCK_SUSPEND', 'CAP_AUDIT_READ', 'CAP_PERFMON', 'CAP_BPF', 'CAP_CHECKPOINT_RESTORE'], 'cgroup': {'v1': True, 'v2': True, 'systemd': True, 'systemdUser': True}, 'seccomp': {'enabled': True, 'actions': ['SCMP_ACT_ALLOW', 'SCMP_ACT_ERRNO', 'SCMP_ACT_KILL', 'SCMP_ACT_KILL_PROCESS', 'SCMP_ACT_KILL_THREAD', 'SCMP_ACT_LOG', 'SCMP_ACT_NOTIFY', 'SCMP_ACT_TRACE', 'SCMP_ACT_TRAP'], 'operators': ['SCMP_CMP_NE', 'SCMP_CMP_LT', 'SCMP_CMP_LE', 'SCMP_CMP_EQ', 'SCMP_CMP_GE', 'SCMP_CMP_GT', 'SCMP_CMP_MASKED_EQ']}, 'apparmor': {'enabled': True}, 'selinux': {'enabled': True}}, 'annotations': {'io.github.seccomp.libseccomp.version': '2.5.3', 'org.opencontainers.runc.checkpoint.enabled': True, 'run.oci.crun.checkpoint.enabled': True, 'io.github.containers.crun.commit': '9738116147984a9fb6d993394f74217b0e532be8', 'io.github.containers.crun.version': '1.8.5.0.0.0.31-33cb'}}
Mismatch in feature: linux
Expected: {'namespaces': ['cgroup', 'ipc', 'mount', 'network', 'pid', 'user', 'uts'], 'capabilities': ['CAP_CHOWN', 'CAP_DAC_OVERRIDE', 'CAP_DAC_READ_SEARCH', 'CAP_FOWNER', 'CAP_FSETID', 'CAP_KILL', 'CAP_SETGID', 'CAP_SETUID', 'CAP_SETPCAP', 'CAP_LINUX_IMMUTABLE', 'CAP_NET_BIND_SERVICE', 'CAP_NET_BROADCAST', 'CAP_NET_ADMIN', 'CAP_NET_RAW', 'CAP_IPC_LOCK', 'CAP_IPC_OWNER', 'CAP_SYS_MODULE', 'CAP_SYS_RAWIO', 'CAP_SYS_CHROOT', 'CAP_SYS_PTRACE', 'CAP_SYS_PACCT', 'CAP_SYS_ADMIN', 'CAP_SYS_BOOT', 'CAP_SYS_NICE', 'CAP_SYS_RESOURCE', 'CAP_SYS_TIME', 'CAP_SYS_TTY_CONFIG', 'CAP_MKNOD', 'CAP_LEASE', 'CAP_AUDIT_WRITE', 'CAP_AUDIT_CONTROL', 'CAP_SETFCAP', 'CAP_MAC_OVERRIDE', 'CAP_MAC_ADMIN', 'CAP_SYSLOG', 'CAP_WAKE_ALARM', 'CAP_BLOCK_SUSPEND', 'CAP_AUDIT_READ', 'CAP_PERFMON', 'CAP_BPF', 'CAP_CHECKPOINT_RESTORE'], 'cgroup': {'v1': True, 'v2': True, 'systemd': True, 'systemdUser': True}, 'seccomp': {'actions': ['SCMP_ACT_ALLOW', 'SCMP_ACT_ERRNO', 'SCMP_ACT_KILL', 'SCMP_ACT_KILL_PROCESS', 'SCMP_ACT_KILL_THREAD', 'SCMP_ACT_LOG', 'SCMP_ACT_NOTIFY', 'SCMP_ACT_TRACE', 'SCMP_ACT_TRAP'], 'operators': ['SCMP_CMP_NE', 'SCMP_CMP_LT', 'SCMP_CMP_LE', 'SCMP_CMP_EQ', 'SCMP_CMP_GE', 'SCMP_CMP_GT', 'SCMP_CMP_MASKED_EQ']}, 'apparmor': {'enabled': True}, 'selinux': {'enabled': True}}
Actual: {'namespaces': ['cgroup', 'ipc', 'mount', 'network', 'pid', 'user', 'uts'], 'capabilities': ['CAP_CHOWN', 'CAP_DAC_OVERRIDE', 'CAP_DAC_READ_SEARCH', 'CAP_FOWNER', 'CAP_FSETID', 'CAP_KILL', 'CAP_SETGID', 'CAP_SETUID', 'CAP_SETPCAP', 'CAP_LINUX_IMMUTABLE', 'CAP_NET_BIND_SERVICE', 'CAP_NET_BROADCAST', 'CAP_NET_ADMIN', 'CAP_NET_RAW', 'CAP_IPC_LOCK', 'CAP_IPC_OWNER', 'CAP_SYS_MODULE', 'CAP_SYS_RAWIO', 'CAP_SYS_CHROOT', 'CAP_SYS_PTRACE', 'CAP_SYS_PACCT', 'CAP_SYS_ADMIN', 'CAP_SYS_BOOT', 'CAP_SYS_NICE', 'CAP_SYS_RESOURCE', 'CAP_SYS_TIME', 'CAP_SYS_TTY_CONFIG', 'CAP_MKNOD', 'CAP_LEASE', 'CAP_AUDIT_WRITE', 'CAP_AUDIT_CONTROL', 'CAP_SETFCAP', 'CAP_MAC_OVERRIDE', 'CAP_MAC_ADMIN', 'CAP_SYSLOG', 'CAP_WAKE_ALARM', 'CAP_BLOCK_SUSPEND', 'CAP_AUDIT_READ', 'CAP_PERFMON', 'CAP_BPF', 'CAP_CHECKPOINT_RESTORE'], 'cgroup': {'v1': True, 'v2': True, 'systemd': True, 'systemdUser': True}, 'seccomp': {'enabled': True, 'actions': ['SCMP_ACT_ALLOW', 'SCMP_ACT_ERRNO', 'SCMP_ACT_KILL', 'SCMP_ACT_KILL_PROCESS', 'SCMP_ACT_KILL_THREAD', 'SCMP_ACT_LOG', 'SCMP_ACT_NOTIFY', 'SCMP_ACT_TRACE', 'SCMP_ACT_TRAP'], 'operators': ['SCMP_CMP_NE', 'SCMP_CMP_LT', 'SCMP_CMP_LE', 'SCMP_CMP_EQ', 'SCMP_CMP_GE', 'SCMP_CMP_GT', 'SCMP_CMP_MASKED_EQ']}, 'apparmor': {'enabled': True}, 'selinux': {'enabled': True}}
not ok 1 - crun-features

I think you will need to enable seccomp locally before running that test.

giuseppe · 2023-06-26T13:12:28Z

def get_linux_capabilities():
capabilities_file = '/proc/self/status'
capabilities = []

with open(capabilities_file, 'r') as file:
    lines = file.readlines()

for line in lines:
    if line.startswith('Cap') and ':' in line:
        cap_name, cap_value = line.split(':', 1)
        cap_name = cap_name.strip()
        cap_value = cap_value.strip()
        if cap_name.startswith('CapBnd:'):
            cap_hex = cap_value.split()
            for cap in cap_hex:
                cap_int = int(cap, 16)
                capabilities.append(cap_int)

return capabilities

we cannot do that. The kernel could have capabilities that libseccomp doesn't know about, so they could still be missing in the crun features json

giuseppe

LGTM

giuseppe · 2023-06-27T07:36:31Z

made some small changes, I'll merge as soon as the CI is green.

@sohankunkerkar something that is not clear to me yet, is how will you use this feature to decide whether wasm is supported or not?

Wouldn't we need to add that information?

AkihiroSuda · 2023-06-27T07:42:11Z

wasm

👍 as a custom annotation (until its JSON property is officially defined in the spec)

giuseppe · 2023-06-27T08:24:35Z

noticed there is something more to fix, I'll push another version

giuseppe · 2023-06-27T08:55:48Z

I've added a patch. Now wasm support is recorded in a custom annotation

giuseppe · 2023-06-27T08:56:07Z

@flouthoc could you please review the last patch?

Fixes: containers#1177 Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>

src/libcrun/container.c

flouthoc · 2023-06-27T09:03:25Z

@giuseppe patch for WASM feature flag looks good to me.

flouthoc

LGTM

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

containers/crun#1237 was merged to master and was tagged `crun-1.8.6' on Jun 27, 2023. Signed-off-by: match man <ppucoder@gmail.com>

1177 fix containers/crun#1237 was merged to master and was tagged `crun-1.8.6' on Jun 27, 2023. Signed-off-by: match man <ppucoder@gmail.com>

The work to support features introduced another point of dependency on libcap that previously wasn't guarded by ifdefs Refs: containers#1237 Signed-off-by: Robert Günzler <r@gnzler.io>

haircommander reviewed Jun 20, 2023

View reviewed changes

src/features.c Outdated Show resolved Hide resolved

sohankunkerkar force-pushed the add-crun-features branch from 2ed1f0b to 33cb00b Compare June 20, 2023 21:13

giuseppe requested changes Jun 21, 2023

View reviewed changes

sohankunkerkar force-pushed the add-crun-features branch 2 times, most recently from 208485e to dd0ff1b Compare June 22, 2023 17:28

giuseppe reviewed Jun 22, 2023

View reviewed changes

src/libcrun/container.c Outdated Show resolved Hide resolved

sohankunkerkar force-pushed the add-crun-features branch 2 times, most recently from 62e582c to a4605dd Compare June 22, 2023 21:38

AkihiroSuda reviewed Jun 23, 2023

View reviewed changes

src/libcrun/container.c Show resolved Hide resolved

AkihiroSuda reviewed Jun 23, 2023

View reviewed changes

src/libcrun/container.c Outdated Show resolved Hide resolved

AkihiroSuda reviewed Jun 23, 2023

View reviewed changes

src/libcrun/container.c Show resolved Hide resolved

sohankunkerkar force-pushed the add-crun-features branch 2 times, most recently from b6a43b0 to 7c8a4b1 Compare June 23, 2023 14:53

AkihiroSuda reviewed Jun 23, 2023

View reviewed changes

src/features.c Outdated Show resolved Hide resolved

sohankunkerkar force-pushed the add-crun-features branch from 7c8a4b1 to 4a965a2 Compare June 23, 2023 15:40

AkihiroSuda approved these changes Jun 23, 2023

View reviewed changes

sohankunkerkar force-pushed the add-crun-features branch from 4162ded to 877ef1c Compare June 23, 2023 19:01

haircommander reviewed Jun 23, 2023

View reviewed changes

.vscode/settings.json Outdated Show resolved Hide resolved

sohankunkerkar force-pushed the add-crun-features branch from 877ef1c to e2ff6cc Compare June 23, 2023 20:04

giuseppe reviewed Jun 24, 2023

View reviewed changes

sohankunkerkar force-pushed the add-crun-features branch 2 times, most recently from eee7303 to 337652b Compare June 25, 2023 04:25

giuseppe reviewed Jun 25, 2023

View reviewed changes

tests/test_oci_features.py Outdated Show resolved Hide resolved

tests/test_oci_features.py Outdated Show resolved Hide resolved

tests/test_oci_features.py Outdated Show resolved Hide resolved

giuseppe reviewed Jun 25, 2023

View reviewed changes

sohankunkerkar force-pushed the add-crun-features branch from 337652b to af8b147 Compare June 26, 2023 03:30

sohankunkerkar force-pushed the add-crun-features branch from af8b147 to 682e103 Compare June 26, 2023 14:44

giuseppe approved these changes Jun 27, 2023

View reviewed changes

giuseppe force-pushed the add-crun-features branch from 5991ad8 to 1d6c429 Compare June 27, 2023 07:46

giuseppe force-pushed the add-crun-features branch from 1d6c429 to 7ab96c6 Compare June 27, 2023 08:55

src/*: implement features

366af73

Fixes: containers#1177 Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>

flouthoc reviewed Jun 27, 2023

View reviewed changes

src/libcrun/container.c Outdated Show resolved Hide resolved

giuseppe force-pushed the add-crun-features branch from 7ab96c6 to ee3ff35 Compare June 27, 2023 09:02

flouthoc approved these changes Jun 27, 2023

View reviewed changes

giuseppe force-pushed the add-crun-features branch 2 times, most recently from e29dd9d to deeef64 Compare June 27, 2023 09:21

sohankunkerkar and others added 2 commits June 27, 2023 11:42

tests: add test for oci_features

935f4fe

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>

features: add wasm annotation

d006733

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

giuseppe force-pushed the add-crun-features branch from deeef64 to d006733 Compare June 27, 2023 09:42

giuseppe merged commit d5e50d3 into containers:main Jun 27, 2023
18 checks passed

sohankunkerkar deleted the add-crun-features branch June 27, 2023 13:21

paravoid mentioned this pull request Aug 1, 2023

Manually added code to otherwise gperf-generated src/libcrun/mount_flags.c #1253

Closed

0xaead added a commit to 0xaead/containerd that referenced this pull request Aug 12, 2023

crun features command is added

d1eb830

containers/crun#1237 was merged to master and was tagged `crun-1.8.6' on Jun 27, 2023. Signed-off-by: match man <ppucoder@gmail.com>

0xaead mentioned this pull request Aug 12, 2023

crun features command is added 0xaead/containerd#1

Open

0xaead added a commit to 0xaead/containerd that referenced this pull request Aug 12, 2023

crun features command is added

9155f9f

containers/crun#1237 was merged to master and was tagged `crun-1.8.6' on Jun 27, 2023. Signed-off-by: match man <ppucoder@gmail.com>

0xaead mentioned this pull request Aug 12, 2023

crun features command is added containerd/containerd#8962

Closed

0xaead added a commit to 0xaead/containerd that referenced this pull request Oct 27, 2023

crun features command is added

db60688

1177 fix containers/crun#1237 was merged to master and was tagged `crun-1.8.6' on Jun 27, 2023. Signed-off-by: match man <ppucoder@gmail.com>

0xaead added a commit to 0xaead/go-runc that referenced this pull request Oct 27, 2023

crun features command is added

21dc3de

1177 fix containers/crun#1237 was merged to master and was tagged `crun-1.8.6' on Jun 27, 2023. Signed-off-by: match man <ppucoder@gmail.com>

0xaead mentioned this pull request Oct 27, 2023

crun features command is added containerd/go-runc#103

Open

robertgzr mentioned this pull request Nov 9, 2023

Fix build without libcap #1345

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement crun features #1237

Implement crun features #1237

sohankunkerkar commented Jun 20, 2023

giuseppe left a comment

giuseppe left a comment

giuseppe Jun 25, 2023

sohankunkerkar Jun 25, 2023

giuseppe Jun 26, 2023

giuseppe commented Jun 26, 2023

giuseppe commented Jun 26, 2023

sohankunkerkar commented Jun 26, 2023 •

edited

Loading

giuseppe commented Jun 26, 2023

giuseppe left a comment

giuseppe commented Jun 27, 2023 •

edited

Loading

AkihiroSuda commented Jun 27, 2023

giuseppe commented Jun 27, 2023

giuseppe commented Jun 27, 2023

giuseppe commented Jun 27, 2023

flouthoc commented Jun 27, 2023

flouthoc left a comment

Implement crun features #1237

Implement crun features #1237

Conversation

sohankunkerkar commented Jun 20, 2023

giuseppe left a comment

Choose a reason for hiding this comment

giuseppe left a comment

Choose a reason for hiding this comment

giuseppe Jun 25, 2023

Choose a reason for hiding this comment

sohankunkerkar Jun 25, 2023

Choose a reason for hiding this comment

giuseppe Jun 26, 2023

Choose a reason for hiding this comment

giuseppe commented Jun 26, 2023

giuseppe commented Jun 26, 2023

sohankunkerkar commented Jun 26, 2023 • edited Loading

giuseppe commented Jun 26, 2023

giuseppe left a comment

Choose a reason for hiding this comment

giuseppe commented Jun 27, 2023 • edited Loading

AkihiroSuda commented Jun 27, 2023

giuseppe commented Jun 27, 2023

giuseppe commented Jun 27, 2023

giuseppe commented Jun 27, 2023

flouthoc commented Jun 27, 2023

flouthoc left a comment

Choose a reason for hiding this comment

sohankunkerkar commented Jun 26, 2023 •

edited

Loading

giuseppe commented Jun 27, 2023 •

edited

Loading