cgroup-resources,cgroupv2: allow setting memory.swap.max to 0
#1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flouthoc
force-pushed
the
cgroupv2-swap-0-honor
branch
from
f276785
to
23c9b92
Compare
Runc accepts `0` value of `swap` from config as an exception case * See: https://github.com/opencontainers/runc/blob/main/libcontainer/cgroups/fs2/memory.go#L36 * See: https://github.com/opencontainers/runc/blob/main/libcontainer/cgroups/utils.go#L431 As per the documentation here: https://facebookmicrosites.github.io/cgroup2/docs/memory-controller.html#using-swap Setting `memory.swap.max` to `0` is treated as `swap` being disabled hence allow `crun` to do the same. Closes: containers#1001 Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
cgroupv2-swap-0-honor
branch
from
23c9b92
to
b160e2c
Compare
|
Failing |
|
@kolyshkin @AkihiroSuda PTAL |
|
LGTM |
AkihiroSuda
approved these changes
Jul 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runc accepts
0value ofswapfrom config as an exception caseAs per the documentation here: https://facebookmicrosites.github.io/cgroup2/docs/memory-controller.html#using-swap Setting
memory.swap.maxto0is treated asswapbeing disabled hence allowcrunto do the same.Closes: #1001