utils: find_executable honors local dir paths #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
reviewed
Oct 16, 2019
| cleanup_free char *tmp = NULL; | ||
| char path[PATH_MAX + 1]; | ||
| int last_error = ENOENT; | ||
| char *it, *end; | ||
| int ret; | ||
|
|
||
| if (executable_path[0] == '.') |
There was a problem hiding this comment.
Should you check to make sure len(executable_path) >0?
There was a problem hiding this comment.
in that case executable_path[0] would be '\0'
There was a problem hiding this comment.
What about if executable_path == null
There was a problem hiding this comment.
that should not happen as the only caller checks for it, but in any case to be safer I've added a new check now
when the executable path has the form ./PATH, make sure the current working directory is used as a prefix. Closes: containers#133 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
honor-dot-executables
branch
from
da9318c
to
7280bea
Compare
|
tests are green |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the executable path has the form ./PATH, make sure the current
working directory is used as a prefix.
Closes: #133
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com