Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support publishing as Docker Engine managed plugin #103

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kale1d0code
Copy link

@kale1d0code kale1d0code commented Aug 10, 2022

I have taken the files from the pull request made by @olljanat that was based on work by @nickbreen found here

To get the plugin to work from within a container I have had to make some changes.

syslog does not run in the context of a container and so the logging library has been replaced from log/syslog to log. I don't know if docker plugins create logs but if they do the docker syslog logging driver could be used to get the original functionality

The plugin requires a config file at /etc/docker/docker-lvm-plugin, This is my first time editing a go project and so I felt it was best to add a volume name to this config file instead of removing the code that checks for it (setting the default volume name should be done by environment variable when running as a managed plugin)

Will allow you close #66

@csoylu
Copy link

csoylu commented Oct 4, 2022

Any updates on this? We need an LVM plugin and I couldn't make the main branch work.

@kale1d0code
Copy link
Author

Due to personal issues, It will be a while until I can pick this back up.

With these changes the plugin starts up without crashing (as a docker managed plugin), however
Something about the volumes being created within a plugin container prevents the volumes being mounted when a container that uses the volume starts.
in fact most of the lv commands from the host stop working against logical volumes created within the plugin, lvdisplay shows docker-lvm-plugin related volumes as read-only.

I don't know enough about lvm and am unable to find enough out about it online to finish the work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin in docker hub?
2 participants