Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate a WSL2 solution of the user space networking stack #139

Open
1 task
gbraad opened this issue Aug 16, 2022 · 10 comments
Open
1 task

Incorporate a WSL2 solution of the user space networking stack #139

gbraad opened this issue Aug 16, 2022 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@gbraad
Copy link
Member

gbraad commented Aug 16, 2022

@sakai135 created https://github.com/sakai135/wsl-vpnkit and it might be a good idea to make this part of the general offering of the user space networking stack.


@gbraad gbraad self-assigned this Oct 19, 2022
@gbraad
Copy link
Member Author

gbraad commented Nov 30, 2022

I hope Keiichi Shimamura (@sakai135) would like to engage in a conversation. Since we have several people working on the stack it would be very beneficial to combine efforts.

@gbraad gbraad added the enhancement New feature or request label Nov 30, 2022
@sakai135
Copy link
Contributor

sakai135 commented Dec 6, 2022

@gbraad It would be great if we could combine/upstream any part or all of wsl-vpnkit to gvisor-tap-vsock.

@gbraad
Copy link
Member Author

gbraad commented Jan 16, 2023

Hi @sakai135, sorry the delays. I was glad to see your emails. A while back I made a few changes to get the WSL2 parts in; https://github.com/gbraad/gvisor-tap-vsock/tree/wsl-gvproxy. What do you think?

@sakai135
Copy link
Contributor

@gbraad Thanks, I'll take a look at it this weekend and maybe see if I can get it a bit more integrated.

@gbraad
Copy link
Member Author

gbraad commented Jan 21, 2023

I will be on PTO/Chinese New Year, so away for a week. Just go ahead.

I'll also try to get you permissions here, but I am not the owner of the org.

@sakai135
Copy link
Contributor

@gbraad Here's my take for a MVP. Omitting the ability to configure IP addresses, this change would enable me to use the vanilla gvisor-tap-vsock binaries in wsl-vpnkit.

main...sakai135:gvisor-tap-vsock:wsl

@gbraad
Copy link
Member Author

gbraad commented Jan 30, 2023

Can you propose this as a PR?
In that case Christophe and Jason can respond directly.

Are there any performance trade-offs with the original usage?

@sakai135
Copy link
Contributor

Created a draft PR #177. This provides the same performance as the original usage in wsl-vpnkit.

@EvertonSA
Copy link

hell yeah, thanks a lot everyone for this effort. My current employer is reluctant to continue with @sakai135 project and this will be really beneficial to us. Thanks a lot, I really really appreciate.

@gbraad
Copy link
Member Author

gbraad commented Mar 10, 2023

We have to cut a release so this can move forward: #139
Release has been cut as 0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants