set proper protocol for stdio #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keiichi Shimamura <sakai135@users.noreply.github.com>
2 tasks
cfergeau
approved these changes
Mar 14, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cfergeau, sakai135 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #177, the stdio connection was relying on the behavior of the virtualnetwork using the protocol specified on the config created in the gvproxy command. #175 changed this to ignore the protocol on the config and use the protocol defined in each of the Accept* methods.
This adds an entry for the stdio connection as a separate type and uses that.