Improvements to the systemd unit file #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve LGTM |
When this is installed in /etc/systemd/system/, the very generic unit name/description can be a problem. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
This will allow to always install gv-user-network.service system-wide. After configuring a tap network device, gv-user-network.service can be enabled/started with: # systemctl enable --now gv-user-network@vsock0 (if the device is named `vsock0`) Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
This ensures that the network device the systemd unit needs exists. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
gv-user-network@.service can be used with any network device, and is not enabled by default, so we can always install it. Once a tap device is configured (for example using contrib/networkmanager/vsock0.nmconnection), user mode networking can be enabled/started with `systemctl enable --now gv-user-network@vsock0' If the service not explicitly enabled/started, the installed unit file won't do anything. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
cfergeau
added a commit
to cfergeau/snc
that referenced
this pull request
Apr 24, 2023
…iner image The service file is based on the upstream one https://github.com/containers/gvisor-tap-vsock/blob/main/contrib/systemd/user-network.service after containers/gvisor-tap-vsock#207 is merged.
|
LGTM |
|
Trying to move this forward following Brent's review |
|
@cfergeau: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This aligns the naming with 'gvproxy' and hopefully makes it a bit more descriptive Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
|
/hold |
|
/hold cancel |
baude
approved these changes
Apr 25, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cfergeau
added a commit
to cfergeau/snc
that referenced
this pull request
Jun 6, 2023
…iner image The service file is based on the upstream one https://github.com/containers/gvisor-tap-vsock/blob/main/contrib/systemd/user-network.service after containers/gvisor-tap-vsock#207 is merged.
cfergeau
added a commit
to cfergeau/snc
that referenced
this pull request
Jul 20, 2023
…iner image The service file is based on the upstream one https://github.com/containers/gvisor-tap-vsock/blob/main/contrib/systemd/user-network.service after containers/gvisor-tap-vsock#207 is merged.
cfergeau
added a commit
to cfergeau/snc
that referenced
this pull request
Aug 29, 2023
…iner image The service file is based on the upstream one https://github.com/containers/gvisor-tap-vsock/blob/main/contrib/systemd/user-network.service after containers/gvisor-tap-vsock#207 is merged.
cfergeau
added a commit
to cfergeau/snc
that referenced
this pull request
Sep 5, 2023
…iner image The service file is based on the upstream one https://github.com/containers/gvisor-tap-vsock/blob/main/contrib/systemd/user-network.service after containers/gvisor-tap-vsock#207 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more generic so that it can be installed by default.
This PR also gives a more descriptive name to the
vmbinary.