-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot delete image from Artifactory #1009
Comments
It would be great to add documentation to https://github.com/jfrog/jfrog-cli/blob/master/artifactory/commands/generic/delete.go looks quite different from the docker/distribution API, so that is probably no help for figuring out if the client is doing something wrong. |
@mtrmac yes. the jfrog cli is using the different API from Docker. It is using the same API for deleting artifacts and it is not compatiable with standard Docker API. I hope that someone could find a solution or an implementation for it. |
Can someone reach out to Jfrog to see if they would be interested in adding support for skopeo or at least explaining what should be done. |
We are also affected by this. |
+1 Here's what the Artifactory documentation has to say on deletion - https://www.jfrog.com/confluence/display/RTF/Docker+Registry#DockerRegistry-DeletionandCleanup The
For Artifactory, skopeo would then have to delete as follows -
|
@mtrmac @vrothberg WDYT? Artifactory has a large enough installed base, that this might make sense to special case it? |
Assuming we can cleanly distinguish artifactory from docker/distribution, sure. It would be great to cover that! |
If initial attempt at removing fails can we just try this method? If second try fails return first error. |
@vrothberg There is a header returned on all api calls that identifies the artifactory server id |
@btashton, brilliant, thanks! We are quite busty over here, so I cannot give any ETA but we're always welcoming contributions. If someone is willing to contribute, we'd be happy to guide them through the code. |
(Let’s use the positive |
This comment has been minimized.
This comment has been minimized.
Hello, I'm taking a look at this; I'll keep you posted :-) |
Well, this is now supported by Artifactory (at least in 7.46.11 where I just tested it). I'm not sure if it's worth it to make a fix for older version, it's hard to find out when exactly this was fixed, if documented at all... |
Thanks for checking. Considering how long this has been open on our side, and that testing the newly-developed code would require deploying some older (increasingly obsolete) version, I’m inclined to close this issue and just recommend upgrading. |
SGTM |
This issue have been already mentioned once here
I am able to inspect/copy the image on Artifactory but I got 406 Not acceptable why I tried to delete the image
The issue above state that is to enable delete config for Docker Registry. However I could not found any document relate to modify config.yml of Artifactory Docker Registry
I obtain the folllowing error
It would be nice to support Artifactory too. We distribute our images to both Artifactory and Openshift Regsitry so right now we need 2 different tool (jfrog cli and skopeo) to cleanup images
The text was updated successfully, but these errors were encountered: