-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c/image/docker depends on compression implementations #1146
Comments
This was referenced Jul 23, 2021
This has become much worse since:
|
mtrmac
changed the title
c/image/manifest depends on compression implementations
c/image/docker depends on compression implementations
Jul 27, 2021
This now seems impossible to fix. We could modify the internal-only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
… via
pkg/compression
, primarily because it refers to algorithm names, see e.g. openshift/oc#737 .This should be possible to resolve by making the algorithm names string constants in
pkg/compression/types
, and using these constants both inpkg/compression
and inmanifest
(e.g.compressiontypes.GzipAlgorithmName
instead ofcompression.Gzip.Name()
), as well as usingpkg/compression/types.Algorithm
instead ofpkg/compression.Algorithm
.The text was updated successfully, but these errors were encountered: