Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage tests are mostly broken when run as root #1729

Closed
mtrmac opened this issue Nov 21, 2022 · 0 comments · Fixed by #2147
Closed

storage tests are mostly broken when run as root #1729

mtrmac opened this issue Nov 21, 2022 · 0 comments · Fixed by #2147
Labels
kind/bug A defect in an existing functionality (or a PR fixing it)

Comments

@mtrmac
Copy link
Collaborator

mtrmac commented Nov 21, 2022

… because, at least, after 2f81372, makeLayer deterministically deadlocks.

It’s been broken for 3 years. Either make the tests used (ideally by avoiding the root requirement, so that they are run during ordinary development; or at least run them in CI, or give up and drop them.
@mtrmac mtrmac added the kind/bug A defect in an existing functionality (or a PR fixing it) label Dec 9, 2022
This was referenced Oct 14, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A defect in an existing functionality (or a PR fixing it)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix and simplify storage tests mtrmac/image
1 participant
@mtrmac