libkrun: add config_size to KipConfig #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slp
requested changes
Aug 17, 2020
let the libkrun user specify the size of the "struct krun_config" to help detecting mismatches between the configuration used by the user of the library and what libkrun handles. If the specified size is bigger than what libkrun uses, then it means there are extra options specified by the user that libkrun cannot honor. We could handle the case where the specified size is less than what libkrun knows and don't handle what is not known to the library user but simplify usage for now and error out in both cases. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
add-config-size
branch
from
410918d
to
835bd8c
Compare
slp
approved these changes
Aug 17, 2020
|
@giuseppe Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let the libkrun user specify the size of the "struct krun_config" to
help detecting mismatches between the configuration used by the user
of the library and what libkrun handles.
If the specified size is bigger than what libkrun uses, then it means
there are extra options specified by the user that libkrun cannot
honor.
We could handle the case where the specified size is less than what
libkrun knows and don't handle what is not known to the library user
but simplify usage for now and error out in both cases.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com