Replace the old vsock device with TSIv2's vsock #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derive "Clone" for Epoll. TSIv2's vsock will need this. Signed-off-by: Sergio Lopez <slp@redhat.com>
Drop use of the kqueue crate making use of the low-level interface exposed via libc instead. This allows us to operate in a way that fits better our need to emulate epoll. Signed-off-by: Sergio Lopez <slp@redhat.com>
Replace the original vsock implementation, coming from Firecracker and slightly modified to support TSI, with a device implementation specifically designed to support TSIv2. TSIv2, in addition of being cleaner (TSI was mostly a PoC), adds support for SOCK_DGRAM, enabling guests to make use of UDP. This is specially useful for DNS, as it removed the need to add "options use-vs" to "/etc/resolv.conf", and enables the use of musl-based OCI images, such as the ones derived from Alpine. Starting this commit, libkrun requires version 2 or later of the libkrunfw payload. Signed-off-by: Sergio Lopez <slp@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.