README: update "out of scope" section #2428

vrothberg · 2019-02-25T14:21:07Z

Remove the Skopeo entry as Podman allows signing and pushing to
various various now.
Mention that Podman does/will not support docker-compose.

Fixes: #746 (comment)
Signed-off-by: Valentin Rothberg rothberg@redhat.com

openshift-ci-robot · 2019-02-25T14:21:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vrothberg · 2019-02-25T14:21:24Z

@baude @mheon @rhatdan @TomSweeneyRedHat PTAL.

mheon · 2019-02-25T14:22:21Z

README.md

@@ -31,10 +31,13 @@ This project tests all builds against each supported version of Fedora, the late

 ## Out of scope

-* Signing and pushing images to various image storages.


Should we leave this, with a note that Podman does it, but we still recommend Skopeo for serious work? Our sign/verify code isn't as mature as theirs

mheon · 2019-02-25T14:22:46Z

README.md

  See [CRI-O](https://github.com/kubernetes-sigs/cri-o).
+* Supporting `docker-compose`.  We believe that Kubernetes is the defacto
+  standard for container orchestration.  Hence, Podman allows to create PODs


Don't all-caps POD, no need

mheon · 2019-02-25T14:22:54Z

README.md

+* Supporting `docker-compose`.  We believe that Kubernetes is the defacto
+  standard for container orchestration.  Hence, Podman allows to create PODs
+  from a Kubernetes YAML file. See
+  [podman-play-kube](https://github.com/containers/libpod/blob/master/docs/podman-play-kube.1.md)


Link generate too

Are you going to add generate too per @mheon's suggestion?

Sorry, the PR is in already. Shall I update? I think that the podman play manpage could mention it as well.

Sure open a new PR.

TomSweeneyRedHat · 2019-02-25T14:41:58Z

README.md

  See [CRI-O](https://github.com/kubernetes-sigs/cri-o).
+* Supporting `docker-compose`.  We believe that Kubernetes is the defacto
+  standard for container orchestration.  Hence, Podman allows to create PODs


suggest: "allows to create PODs" to "allows the creation of Pods"

AkihiroSuda · 2019-02-25T14:48:59Z

The equivalent of docker network create is also out of scope?

mheon · 2019-02-25T15:08:44Z

I think a podman network command would be a fine addition, though what we can do with it is a bit more limited by Podman's architecture and CNI (for example, we can't easily attach existing containers to new networks, due to Podman's immutable container model). But I would be happy to accept patches implementing what we can do, so I wouldn't say it's out of scope

Also mention that Podman does/will not support `docker-compose`. Fixes: containers#746 (comment) Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

vrothberg · 2019-02-25T16:04:33Z

Updated, @mheon & @TomSweeneyRedHat, thanks for the comments!

mheon · 2019-02-25T16:27:42Z

LGTM

rhatdan · 2019-02-25T16:43:56Z

@TomSweeneyRedHat PTAL

TomSweeneyRedHat · 2019-02-25T18:41:40Z

README.md

-  See [Skopeo](https://github.com/containers/skopeo/).
-* Container Runtimes daemons for working with the Kubernetes CRI interface.
-  See [CRI-O](https://github.com/kubernetes-sigs/cri-o).
+* Specializing in signing and pushing images to various storage backends.


I like how you handled this @vrothberg

Conan-Kudo · 2019-02-25T20:06:22Z

README.md

+  [CRI-O](https://github.com/kubernetes-sigs/cri-o) specializes in that.
+* Supporting `docker-compose`.  We believe that Kubernetes is the defacto
+  standard for container orchestration.  Hence, Podman allows the creation of
+  Pods from a Kubernetes YAML file. See


This doesn't make sense as a term for out of scope. docker-compose is not the same as Docker Swarm. Essentially, docker-compose is a way to spin up a pod on your machine using your single container engine instance.

Making someone deploy Kubernetes for that is madness. However, it is nice that podman can generate Kubernetes YAML for translation to a Kubernetes system, it makes no sense to not have the facility built in so that people can develop these things to eventually host in an OpenShift/Kubernetes system.

docker compose is not part of Docker it is a separate project. And it is Huge. So we currently do not have the man power to do everything that is involved in doing this. If someone wants to start a project called podman-compose, then we would support them.

We don't want to force anyone to do kubernetes. We are just suggesting alternatives and looking at the problem from a different point of view.

This doesn't make sense as a term for out of scope. docker-compose is not the same as Docker Swarm. Essentially, docker-compose is a way to spin up a pod on your machine using your single container engine instance.

Right. You can use podman play kube in a similar fashion but with Kubernetes yaml.

Making someone deploy Kubernetes for that is madness. However, it is nice that podman can generate Kubernetes YAML for translation to a Kubernetes system, it makes no sense to not have the facility built in so that people can develop these things to eventually host in an OpenShift/Kubernetes system.

I suggest cooling down a bit.

Noone is forcing users into Kubernetes. podman play kube is meant for the exact use-case you describe but it requires a Kubernetes yaml instead of Compose yaml.

You were referring to podman generate kube which generates this yaml file based on a set of containers/pods and allows migrating to Kubernetes, if desired.

However, the text must be corrected as it was meant to refer to podman-play-kube.

However, the text must be corrected as it was meant to refer to podman-play-kube.

Actually, it's fine in this regard: "Hence, Podman allows the creation of Pods from a Kubernetes YAML file."

Not sure if we should avoid mentioning "orchestrating" and rephrase it.

rhatdan · 2019-02-26T09:23:43Z

/lgtm

Based on user feedback, refine the "Out of scope" section regarding `docker-compose`: * Explain why Podman uses Kubernetes YAML. * Explain how `podman-play-kube` and `podman-generate-kube` fit into the picture. Addresses: containers#2428 (comment) Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

Addresses: containers#2428 (comment) Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

Based on user feedback, refine the "Out of scope" section regarding `docker-compose`: * Explain why Podman uses Kubernetes YAML. * Explain how `podman-play-kube` and `podman-generate-kube` fit into the picture. Addresses: containers#2428 (comment) Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

Addresses: containers#2428 (comment) Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

Based on user feedback, refine the "Out of scope" section regarding `docker-compose`: * Explain why Podman uses Kubernetes YAML. * Explain how `podman-play-kube` and `podman-generate-kube` fit into the picture. Addresses: containers#2428 (comment) Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

Addresses: containers#2428 (comment) Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

openshift-ci-robot requested review from mheon and rhatdan February 25, 2019 14:21

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2019

openshift-ci-robot added the size/XS label Feb 25, 2019

mheon reviewed Feb 25, 2019

View reviewed changes

TomSweeneyRedHat reviewed Feb 25, 2019

View reviewed changes

README: update "out of scope" section

af8f29b

Also mention that Podman does/will not support `docker-compose`. Fixes: containers#746 (comment) Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

vrothberg force-pushed the docker-compose-out-of-scope branch from 77de13c to af8f29b Compare February 25, 2019 16:04

openshift-ci-robot added size/S and removed size/XS labels Feb 25, 2019

vrothberg mentioned this pull request Feb 25, 2019

Running containers inside of a container environment (with docker-compose.yml) using podman? #746

Closed

TomSweeneyRedHat reviewed Feb 25, 2019

View reviewed changes

Conan-Kudo reviewed Feb 25, 2019

View reviewed changes

openshift-ci-robot assigned rhatdan Feb 26, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2019

openshift-merge-robot merged commit 05450f3 into containers:master Feb 26, 2019

vrothberg deleted the docker-compose-out-of-scope branch February 26, 2019 10:00

vrothberg added a commit to vrothberg/libpod that referenced this pull request Feb 26, 2019

docs: cross-reference podman-{generate,play}-kube

e7dd9f1

Addresses: containers#2428 (comment) Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

vrothberg added a commit to vrothberg/libpod that referenced this pull request Feb 26, 2019

docs: cross-reference podman-{generate,play}-kube

fd9a80a

Addresses: containers#2428 (comment) Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

vrothberg added a commit to vrothberg/libpod that referenced this pull request Feb 26, 2019

docs: cross-reference podman-{generate,play}-kube

8a27b1a

Addresses: containers#2428 (comment) Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

vrothberg added a commit to vrothberg/libpod that referenced this pull request Feb 26, 2019

docs: cross-reference podman-{generate,play}-kube

7fea0d7

Addresses: containers#2428 (comment) Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

README: update "out of scope" section #2428

README: update "out of scope" section #2428

vrothberg commented Feb 25, 2019

openshift-ci-robot commented Feb 25, 2019

vrothberg commented Feb 25, 2019

mheon Feb 25, 2019

mheon Feb 25, 2019

mheon Feb 25, 2019

TomSweeneyRedHat Feb 25, 2019

vrothberg Feb 26, 2019

rhatdan Feb 26, 2019

TomSweeneyRedHat Feb 25, 2019

AkihiroSuda commented Feb 25, 2019

mheon commented Feb 25, 2019

vrothberg commented Feb 25, 2019

mheon commented Feb 25, 2019

rhatdan commented Feb 25, 2019

TomSweeneyRedHat Feb 25, 2019

Conan-Kudo Feb 25, 2019

rhatdan Feb 25, 2019

vrothberg Feb 26, 2019

vrothberg Feb 26, 2019

rhatdan commented Feb 26, 2019

		@@ -31,10 +31,13 @@ This project tests all builds against each supported version of Fedora, the late

		## Out of scope

		* Signing and pushing images to various image storages.

README: update "out of scope" section #2428

README: update "out of scope" section #2428

Conversation

vrothberg commented Feb 25, 2019

openshift-ci-robot commented Feb 25, 2019

vrothberg commented Feb 25, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AkihiroSuda commented Feb 25, 2019

mheon commented Feb 25, 2019

vrothberg commented Feb 25, 2019

mheon commented Feb 25, 2019

rhatdan commented Feb 25, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhatdan commented Feb 26, 2019