Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated install.md for Manjaro Linux #3242

Merged
merged 3 commits into from Jul 3, 2019
Merged

Updated install.md for Manjaro Linux #3242

merged 3 commits into from Jul 3, 2019

Conversation

adel-mamin
Copy link
Contributor

The PR adds some more details about installing and using libpod on Manjaro Linux.
This is a follow-up PR for the issue #3207

@rh-atomic-bot
Copy link
Collaborator

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@openshift-ci-robot openshift-ci-robot added size/S needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2019
@openshift-ci-robot
Copy link
Collaborator

Hi @adel-mamin. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adel-mamin adel-mamin mentioned this pull request May 31, 2019
Closed
@giuseppe
Copy link
Member

/ok-to-test

could you re-push after you git commit --amend -s your patch?

@openshift-ci-robot openshift-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2019
@adel-mamin adel-mamin force-pushed the adel-mamin/install-md-update-for-manjaro branch from b329084 to f56ed79 Compare May 31, 2019 08:44
@adel-mamin
Copy link
Contributor Author

could you re-push after you git commit --amend -s your patch?

Done.

@giuseppe
Copy link
Member

/approve

LGTM

the CI failures are not related to this PR

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adel-mamin, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2019
TomSweeneyRedHat
TomSweeneyRedHat reviewed May 31, 2019
View reviewed changes
install.md Outdated
```

If not, please update the kernel.
For Manjaro Linux the instructions could be found here:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/could/can

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

TomSweeneyRedHat
TomSweeneyRedHat reviewed May 31, 2019
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit to fix up, otherwise LGTM. Thanks @adel-mamin !

@TomSweeneyRedHat
Copy link
Member

LGTM but it looks like you've an extra space at the end of a line or two that you changed that's making git validate unhappy....

@adel-mamin adel-mamin force-pushed the adel-mamin/install-md-update-for-manjaro branch from 2b89097 to 605874a Compare May 31, 2019 20:57
rhatdan
rhatdan reviewed Jun 1, 2019
View reviewed changes
install.md
After that enable user namespaces:

```
sudo sysctl kernel.unprivileged_userns_clone=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to make this permanent? IE Drop a file into /etc/sysctl.d?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the instruction to make it permanently. I verified it on my Manjaro Linux machine.

@rhatdan
Copy link
Member

rhatdan commented Jun 8, 2019

@adel-mamin Ping

@adel-mamin adel-mamin force-pushed the adel-mamin/install-md-update-for-manjaro branch from 5dfc202 to 440334c Compare June 9, 2019 12:35
@rhatdan
Copy link
Member

rhatdan commented Jun 10, 2019

LGTM

@TomSweeneyRedHat
Copy link
Member

Change LGTM
Tests are unhappy though, I can't image that's due to this PR though.

@giuseppe
Copy link
Member

giuseppe commented Jul 2, 2019

@adel-mamin could you please rebase this PR?

@adel-mamin
Updated install.md for Manjaro Linux
08bd05c 
Signed-off-by: Adel Mamin <adel.mamin@exafore.com>
@adel-mamin
Addressed code review comments
229c5d6 
Signed-off-by: Adel Mamin <adel.mamin@exafore.com>
@adel-mamin
Added instruction to enable the user namespaces permanenty in Manjaro
ac72229 
Signed-off-by: Adel Mamin <adel.mamin@exafore.com>
@adel-mamin adel-mamin force-pushed the adel-mamin/install-md-update-for-manjaro branch from 440334c to ac72229 Compare July 3, 2019 09:39
@adel-mamin
Copy link
Contributor Author

@giuseppe Done.

@mheon
Copy link
Member

mheon commented Jul 3, 2019

LGTM on my end
@TomSweeneyRedHat PTAL

TomSweeneyRedHat
TomSweeneyRedHat reviewed Jul 3, 2019
View reviewed changes
install.md
```

If not, please update the kernel.
For Manjaro Linux the instructions can be found here:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer [here](https://wiki.manjaro.org/index.php/Manjaro_Kernels)
But not enough to hold the PR up, but a touchup at some point in the future.

@TomSweeneyRedHat
Copy link
Member

One nit, otherwise LGTM. OK to merge with a follow up at some point.

@mheon
Copy link
Member

mheon commented Jul 3, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2019
@openshift-merge-robot openshift-merge-robot merged commit 0e8b66c into containers:master Jul 3, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhatdan rhatdan rhatdan left review comments

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@giuseppe giuseppe Awaiting requested review from giuseppe

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@adel-mamin @rh-atomic-bot @openshift-ci-robot @giuseppe @TomSweeneyRedHat @rhatdan @mheon @openshift-merge-robot