If container is not in correct state podman exec should exit with 126

[rhatdan]

This way a tool can determine if the container exists or not, but is in the
wrong state.

Since 126 is documeted as:
126 if the contained command cannot be invoked

It makes sense that the container would exit with this state.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mbaldessari]

I tested this and can confirm it works. Previous behaviour:

[root@controller-0 ~]# podman exec nonexisting /bin/true; echo $?
unable to exec into nonexisting: no container with name or ID nonexisting found: no such container
125
# memcached is stopped
[root@controller-0 ~]# podman exec memcached /bin/true; echo $?
cannot exec into container that is not running
125

After I patched podman with this review:

 [root@undercloud-0 ~]# podman exec nonexisting /bin/true; echo $?
Error: unable to exec into nonexisting: no container with name or ID nonexisting found: no such container
125
 [root@undercloud-0 ~]# podman exec memcached /bin/true; echo $?                                                                                                                                                                                                                 
Error: cannot exec into container that is not running: container state improper
126

Thanks again!

[TomSweeneyRedHat]

LGTM and happy green test buttons.

[mheon]

/lgtm