Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pip requirements file for rtd #4322

Merged
merged 1 commit into from Oct 23, 2019
Merged

add pip requirements file for rtd #4322

merged 1 commit into from Oct 23, 2019

Conversation

baude
Copy link
Member

@baude baude commented Oct 22, 2019

read the docs requires a pip requirements file to build markdown files
instead of the rst format.

Signed-off-by: baude bbaude@redhat.com

@baude
add pip requirements file for rtd
371af43 
read the docs requires a pip requirements file to build markdown files
instead of the rst format.

Signed-off-by: baude <bbaude@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS labels Oct 22, 2019
@TomSweeneyRedHat
Copy link
Member

Change LGTM, but tests aren't hip

@ssbarnea
Copy link
Collaborator

check-rdo

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@baude
Copy link
Member Author

baude commented Oct 23, 2019

check-rdo

@mheon
Copy link
Member

mheon commented Oct 23, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@ssbarnea
Copy link
Collaborator

check-rdo

@softwarefactory-project-zuul
Copy link

Build succeeded (check pipeline).

@openshift-merge-robot openshift-merge-robot merged commit 2e6c9aa into containers:master Oct 23, 2019
@baude baude deleted the rtdrequirements branch December 22, 2019 19:10
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mheon mheon Awaiting requested review from mheon

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@baude @openshift-ci-robot @TomSweeneyRedHat @ssbarnea @mheon @openshift-merge-robot