New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable btrfs for RHEL in podman spec #4587
Conversation
Hi @raukadah. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I would prefer that we do this in the contrib/spec rather then put intelligence into the the main line code for Red Hat. |
@rhatdan In TripleO CI side, on RHEL-8, we wanted to use bash ./contrib/build_rpm.sh script to generate the rpm from checked out patch, so that required dependencies should be automatically gets installed in CI, we checked that part also. |
Since btrfs-progs-devel is not available in RHEL/CentOS 8 and the spec fails to build it while running build_rpm.sh, making it optional fixes the issue. It also modifies the spec file to install btrfs-progs-devel for fedora only. Since golang-github-cpuguy83-go-md2man was added twice, it also removes the repetition. Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
LGTM |
/assign @baude |
Longer term it would be nice to add a |
Thanks @raukadah |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raukadah, rhatdan, ssbarnea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since btrfs-progs-devel is not available in RHEL8 and the spec
fails to build it. Making the btrfs conditional in spec file
as well as build_rpm.sh fixes the issue.
Signed-off-by: Chandan Kumar (raukadah) raukadah@gmail.com