Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow exec to read files of environment variables #4677

Merged
merged 1 commit into from Dec 11, 2019
Merged

allow exec to read files of environment variables #4677

merged 1 commit into from Dec 11, 2019

Conversation

baude
Copy link
Member

@baude baude commented Dec 11, 2019

we want the ability to define environment variables in files for the
exec command.

Fixes: #1782408

Signed-off-by: baude bbaude@redhat.com

@baude
allow exec to read files of environment variables
a332825 
we want the ability to define environment variables in files for the
exec command.

Fixes: #1782408

Signed-off-by: baude <bbaude@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019
@mheon
Copy link
Member

mheon commented Dec 11, 2019

LGTM

@rhatdan
Copy link
Member

rhatdan commented Dec 11, 2019

Does this actually work. I see changes to the CLI, but not calls that actually use the env-file. Or is this just built into libpod, since the code is using the same code as run/create?
Having a test would have assuaged my fears.

@baude
Copy link
Member Author

baude commented Dec 11, 2019

it works yes

@jwhonce
Copy link
Member

jwhonce commented Dec 11, 2019

pending version branch
/hold
/lgtm

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Dec 11, 2019
TomSweeneyRedHat
TomSweeneyRedHat reviewed Dec 11, 2019
View reviewed changes
docs/source/markdown/podman-exec.1.md
**--env-file**=*file*

Read in a line delimited file of environment variables.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an example of what such a line would look like would be awesome down in the examples section.

@TomSweeneyRedHat
Copy link
Member

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1782408

@rhatdan
Copy link
Member

rhatdan commented Dec 11, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit f81f15f into containers:master Dec 11, 2019
@baude baude deleted the execenvfile branch December 22, 2019 18:50
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@jwhonce jwhonce Awaiting requested review from jwhonce

@mheon mheon Awaiting requested review from mheon

Assignees

@jwhonce jwhonce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@baude @openshift-ci-robot @mheon @rhatdan @jwhonce @TomSweeneyRedHat @openshift-merge-robot