New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
markdown: fix grammar/formatting, standardize on markdown #4951
Conversation
While fixing grammar and list formatting issues, standardize on markdown as follows: - commands are marked by '**' - files are marked by backquotes - list items are marked with leading '-' Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Hi @rpjday. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
LGTM |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is clearly desired but without any regression measure is hard to keep the quality.
How about adding markdownlint to the linters? The only issue with it is that is ruby based.
I'm still trying to figure out what flavour of Markdown is being used. I spent some time yesterday perusing the Intertoobz for MD references, and there are all these subtle variations. And the more I learned, the more I realized that there are a lot of subtle errors in the man page .md files that generate bad rendering. I'd love it if there was a definitive reference for what is being used here. |
Well the markdown is for display on github.com, we really do not share it in other places. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, rpjday The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
While fixing grammar and list formatting issues, standardize on
markdown as follows:
Signed-off-by: Robert P. J. Day rpjday@crashcourse.ca