Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown: fix grammar/formatting, standardize on markdown #4951

Merged
merged 1 commit into from Jan 30, 2020

Conversation

rpjday
Copy link
Contributor

@rpjday rpjday commented Jan 23, 2020

While fixing grammar and list formatting issues, standardize on
markdown as follows:

  • commands are marked by '**'
  • files are marked by backquotes
  • list items are marked with leading '-'

Signed-off-by: Robert P. J. Day rpjday@crashcourse.ca

While fixing grammar and list formatting issues, standardize on
markdown as follows:

  - commands are marked by '**'
  - files are marked by backquotes
  - list items are marked with leading '-'

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
@openshift-ci-robot
Copy link
Collaborator

Hi @rpjday. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/S needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2020
@TomSweeneyRedHat
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2020
@TomSweeneyRedHat
Copy link
Member

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 26, 2020

/lgtm
Thanks @rpjday

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2020
Copy link
Collaborator

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is clearly desired but without any regression measure is hard to keep the quality.
How about adding markdownlint to the linters? The only issue with it is that is ruby based.

@rpjday
Copy link
Contributor Author

rpjday commented Jan 30, 2020

I'm still trying to figure out what flavour of Markdown is being used. I spent some time yesterday perusing the Intertoobz for MD references, and there are all these subtle variations. And the more I learned, the more I realized that there are a lot of subtle errors in the man page .md files that generate bad rendering. I'd love it if there was a definitive reference for what is being used here.

@rhatdan
Copy link
Member

rhatdan commented Jan 30, 2020

Well the markdown is for display on github.com, we really do not share it in other places.

@mheon
Copy link
Member

mheon commented Jan 30, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, rpjday

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit 1729350 into containers:master Jan 30, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants