vendor github.com/containers/image/v5@v5.2.0

[vrothberg]

See release notes:
https://github.com/containers/image/releases/tag/v5.2.0

Fixes: #4877
Signed-off-by: Valentin Rothberg rothberg@redhat.com

[mheon]

LGTM pending green tests

[vrothberg]

/test images

[vrothberg]

/test images

[vrothberg]

gcc errors for preamble:
In file included from _build/src/github.com/containers/libpod/vendor/github.com/mtrmac/gpgme/data.go:6:0:
./go_gpgme.h:15:1: error: unknown type name 'gpgme_off_t'
 extern gpgme_off_t gogpgme_data_seek(gpgme_data_t dh, gpgme_off_t offset, int whence);
 ^
./go_gpgme.h:15:55: error: unknown type name 'gpgme_off_t'
 extern gpgme_off_t gogpgme_data_seek(gpgme_data_t dh, gpgme_off_t offset, int whence);
                                                       ^

@cevich any chance we can get add fresher centos?

[mheon]

The image used for ci/prow/images lives in Openshift CI, but I forget where the dockerfiles are stored - @baude do you remember?

[vrothberg]

Please do not merge until we have @mtrmac 's ACK on the gpg issue.

[mtrmac]

gpgme_off_t was defined in 1.4.1 > 1.3.2, I’m afraid I missed this new reference when updating the mtrmac/gpgme fork.

Note to self, for now: GPGME_VERSION_NUMBER exists in current versions, but not in 1.3.2. How to detect whether to add a typedef?

[mtrmac]

This should be fixed in github.com/mtrmac/gpgme@v0.1.2; hopefully Dependabot will propagate that throughout the stack (like containers/image#810 ), though a new c/image release explicitly dragging it in might make sense anyway.

(Sadly, with semantic versioning enforcing vX.Y.Z, we can’t make a v0.1.1.1, and the version will drift from proglottis/gpgme. The alternative, using something like v0.1.2-mtrmac.1, would not be picked up by other consumers by default.)

[vrothberg]

Ready to be merged. @TomSweeneyRedHat @rhatdan @mtrmac @mheon @baude PTAL

[mheon]

Restarted two flakes, LGTM once things go green

[TomSweeneyRedHat]

LGTM assuming happy tests. Some tests still look unhappy though.

[vrothberg]

The Cirrus tests are running but somehow GitHub and Cirrus are not playing along very well for a while so the web UI is not showing that the tests are (re) running.

Finger's crossed 🤞

[mtrmac]

LGTM.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

/lgtm