Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiv2 addition of manifests #5449

Merged
merged 1 commit into from Mar 17, 2020
Merged

apiv2 addition of manifests #5449

merged 1 commit into from Mar 17, 2020

Conversation

baude
Copy link
Member

@baude baude commented Mar 10, 2020

add endpoints for create, add, remove, inspect, and push. this allows manifests to be managed through the restful interfaces.

also added go-bindings and tests

Signed-off-by: Brent Baude bbaude@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL labels Mar 10, 2020
@baude baude force-pushed the manifests branch 2 times, most recently from cf6a187 to e70d899 Compare March 10, 2020 17:33
@baude
Copy link
Member Author

baude commented Mar 10, 2020

@nalind PTAL

jwhonce
jwhonce requested changes Mar 11, 2020
View reviewed changes
pkg/api/handlers/libpod/manifests.go Outdated Show resolved Hide resolved
pkg/api/handlers/libpod/manifests.go Outdated Show resolved Hide resolved
pkg/api/handlers/libpod/manifests.go Outdated Show resolved Hide resolved
pkg/api/server/register_manifest.go Show resolved Hide resolved
pkg/api/server/register_manifest.go Show resolved Hide resolved
pkg/api/server/register_manifest.go Outdated Show resolved Hide resolved
pkg/bindings/manifests/manifests.go Show resolved Hide resolved
libpod/image/manifests.go Outdated Show resolved Hide resolved
@baude baude force-pushed the manifests branch 3 times, most recently from 95f7b47 to fac42dd Compare March 12, 2020 18:42
@rhatdan
Copy link
Member

rhatdan commented Mar 16, 2020

LGTM

@rhatdan
Copy link
Member

rhatdan commented Mar 16, 2020

@giuseppe @TomSweeneyRedHat @vrothberg @jwhonce @mheon PTAL

vrothberg
vrothberg reviewed Mar 16, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mheon
mheon reviewed Mar 16, 2020
View reviewed changes
libpod/image/manifests.go Outdated Show resolved Hide resolved
@baude
apiv2 addition of manifests
abbbeac 
add endpoints for create, add, remove, inspect, and push.  this allows manifests to be managed through the restful interfaces.

also added go-bindings and tests

Signed-off-by: Brent Baude <bbaude@redhat.com>
@baude
Copy link
Member Author

baude commented Mar 16, 2020

fixed up

@rhatdan
Copy link
Member

rhatdan commented Mar 16, 2020

@baude Needs a rebase.

@baude
Copy link
Member Author

baude commented Mar 17, 2020

merge me please

vrothberg
vrothberg reviewed Mar 17, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9ef5d28 into containers:master Mar 17, 2020
@baude baude deleted the manifests branch May 7, 2020 13:11
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mheon mheon mheon left review comments

@vrothberg vrothberg vrothberg left review comments

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@jwhonce jwhonce jwhonce requested changes

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@baude @openshift-ci-robot @rhatdan @jwhonce @mheon @vrothberg @TomSweeneyRedHat @openshift-merge-robot